Repository navigation
fix(cli): reject negative --seeds instead of silently running defaults - #32
Merged
Merged
Conversation
chronos sweep --seeds=-3 silently ignored the negative value and ran the default 1000-seed sweep with exit 0. Negative values now reach validation and fail fast with a clear error (exit 2).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
chronos sweep --seeds=-3silently ignored the negative value and ran the default 1000-seed sweep with exit 0. Reproduced with the built binary before the fix (the existing test passed vacuously).Fix
Negative values now reach validation and fail fast:
ERROR sweep seeds must be a positive integer, exit 2. Regression test strengthened plus a new positional--3case.Verification
dist/not built, CI builds first)tsc+eslintcleanNote: unknown
--flagsin the seeds position now error instead of being silently ignored — flagging in case that's release-note worthy.