Skip to content

Conversation

@nono-lqdn
Copy link
Contributor

Hello,

This pull request introduces two changes ;

  1. We are now installing the development dependencies, regardless of the NODE_ENV, because following the issue at Building of the admin UI in production is not possible ether/etherpad-lite#7040 , we need them to build the admin UI, even if we are in a production environment.
  2. To be able to do this and build Etherpad-lite when the cloning of the git repository has changed files, we are now using the listen keyword to be able to run two handlers.
    2.1 We've also clarified that the cloning of the git repository is not forced, which was the case before.

This pull request complements #108

Copy link
Member

@0x46616c6b 0x46616c6b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would simplify that:

The notifier should install devDependencies, build Etherpad, and remove the devDependencies. The variable etherpad_node_environment should only be used for the systemd unit to ensure the Node environment is set to production.

@nono-lqdn nono-lqdn force-pushed the main branch 2 times, most recently from 9224b9d to b254cc9 Compare September 2, 2025 15:06
@nono-lqdn
Copy link
Contributor Author

I've included the changes, and update the branch to match main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants