Don't follow recursive symlinks during project discovery #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/recursive-symlinks
branch
2 times, most recently
from
b7e06e3 to
85be4da
Compare
thecrypticace
force-pushed
the
fix/recursive-symlinks
branch
from
85be4da to
72413a4
Compare
thecrypticace
force-pushed
the
feat/windows-ci
branch
from
d71e2b0 to
7975fc7
Compare
thecrypticace
force-pushed
the
fix/recursive-symlinks
branch
from
72413a4 to
3d6c5db
Compare
philipp-spiess
approved these changes
Mar 25, 2025
packages/tailwindcss-language-server/src/project-locator.test.ts
Outdated
Show resolved
Hide resolved
thecrypticace
force-pushed
the
fix/recursive-symlinks
branch
2 times, most recently
from
4dd28cd to
d6c204b
Compare
This is required for the tests to function properly on Windows
thecrypticace
force-pushed
the
fix/recursive-symlinks
branch
from
d6c204b to
0cbc1ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project discovery is done by crawling the workspace with
fast-globlooking for CSS files, JS/TS config files, Sass/Less files, etc…A major problem with this approach though is that
fast-globcrawls the filesystem and traverses into symlinked directories. If the symlink points back to a parent folder the crawler may cause a handful of issues:I've rewritten the traversal to use
tinyglobbywhich is afast-glob-compatible replacement. It avoids all of these issues due to its use offdirwhich explicitly detects and avoids traversal of recursive symlinks.All existing tests pass as well as an additional test that previously timed out due to the use of recursive symlinks. This PR is going to require extensive testing on Windows with network shares, mapped drives, etc…
Fixes #1056
Fixes #1185