Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :popover-open variant #12148

Closed
wants to merge 1 commit into from

Conversation

lukewarlow
Copy link
Contributor

@lukewarlow lukewarlow commented Oct 5, 2023

:popover-open is used to style elements with the popover attribute when they're open.

This is supported in Chromium 114, Safari 17, and Firefox 125.

@lukewarlow lukewarlow force-pushed the popover-open branch 2 times, most recently from 7188384 to c0dd091 Compare October 5, 2023 22:05
@RobinMalfait RobinMalfait force-pushed the popover-open branch 2 times, most recently from a7e03e8 to 4291d1e Compare October 9, 2023 15:53
@brandonmcconnell
Copy link
Contributor

I can see that all major browsers will soon support this now (caniuse). It's behind a feature flag in FF and is currently being tested in Safari TP.

I think it could be a great idea to get this in soon so it's ready for release. Popovers are a great new addition to the web platform, and it would be awesome to add support for pseudos like this to be able to take advantage of such new features in Tailwind CSS.

Thanks, @lukewarlow! Fan of this 🙌🏼

@lukewarlow
Copy link
Contributor Author

Just a minor correction it's actually in Safari 17, MDN is incorrect.

@brandonmcconnell
Copy link
Contributor

Weird, my computer isn't letting me update to Safari 17, so I figured it was still in TP, but maybe it's live?

@thecrypticace
Copy link
Contributor

Safari 17 is definitely available. Has been for a little over 2 weeks. Works on Monterey, Ventura, and Sonoma but I'd imagine only if you're on the latest version of each. Make sure you're updated? Also I'd verify that you don't have a beta development profile (or in later macOS versions have beta updates enabled in Settings)

Copy link

@GeorgeCht GeorgeCht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌

@adamwathan adamwathan changed the base branch from master to archive/master-2024-02-23 March 4, 2024 21:42
@lukewarlow lukewarlow changed the base branch from archive/master-2024-02-23 to master March 5, 2024 13:29
@lukewarlow
Copy link
Contributor Author

This should be up to date with latest master now (have rebased). Let me know if there's anything else I should do.

@adamwathan
Copy link
Member

Thanks for this! Going to target v4 with this one instead, have opened a new PR and added you as a co-author here:

#13331

@adamwathan adamwathan closed this Mar 22, 2024
@lukewarlow lukewarlow deleted the popover-open branch December 10, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants