Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :popover-open variant #12148

Closed
wants to merge 1 commit into from
Closed

Add :popover-open variant #12148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Sort arbitrary properties alphabetically across multiple class lists ([#12911](https://github.com/tailwindlabs/tailwindcss/pull/12911))
- Add `mix-blend-plus-darker` utility ([#12923](https://github.com/tailwindlabs/tailwindcss/pull/12923))

### Added

- Add `:popover-open` variant ([#12148](https://github.com/tailwindlabs/tailwindcss/pull/12148))

## [3.4.1] - 2024-01-05

### Fixed
Expand Down
1 change: 1 addition & 0 deletions src/corePlugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ export let variantPlugins = {
],
'target',
['open', '&[open]'],
'popover-open',

// Forms
'default',
Expand Down
12 changes: 12 additions & 0 deletions tests/variants.oxide.test.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@
.open\:bg-red-200[open] {
background-color: #fecaca;
}
.popover-open\:bg-red-200:popover-open {
background-color: #fecaca;
}
.default\:shadow-md:default,
.checked\:shadow-md:checked,
.indeterminate\:shadow-md:indeterminate,
Expand Down Expand Up @@ -184,6 +187,9 @@
.open\:hover\:bg-red-200:hover[open] {
background-color: #fecaca;
}
.popover-open\:hover\:bg-red-200:hover:popover-open {
background-color: #fecaca;
}
.focus\:shadow-md:focus,
.focus\:hover\:shadow-md:hover:focus,
.focus-visible\:shadow-md:focus-visible,
Expand All @@ -208,6 +214,9 @@
.group[open] .group-open\:bg-red-200 {
background-color: #fecaca;
}
.group:popover-open .group-popover-open\:bg-red-200 {
background-color: #fecaca;
}
.group:default .group-default\:shadow-md,
.group:checked .group-checked\:shadow-md,
.group:indeterminate .group-indeterminate\:shadow-md,
Expand Down Expand Up @@ -267,6 +276,9 @@
.peer[open] ~ .peer-open\:bg-red-200 {
background-color: #fecaca;
}
.peer:popover-open ~ .peer-popover-open\:bg-red-200 {
background-color: #fecaca;
}
.peer:default ~ .peer-default\:shadow-md,
.peer:checked ~ .peer-checked\:shadow-md,
.peer:indeterminate ~ .peer-indeterminate\:shadow-md,
Expand Down
16 changes: 16 additions & 0 deletions tests/variants.test.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,10 @@
--tw-bg-opacity: 1;
background-color: rgb(254 202 202 / var(--tw-bg-opacity));
}
.popover-open\:bg-red-200:popover-open {
--tw-bg-opacity: 1;
background-color: rgb(254 202 202 / var(--tw-bg-opacity));
}
.default\:shadow-md:default,
.checked\:shadow-md:checked,
.indeterminate\:shadow-md:indeterminate,
Expand Down Expand Up @@ -249,6 +253,10 @@
--tw-bg-opacity: 1;
background-color: rgb(254 202 202 / var(--tw-bg-opacity));
}
.popover-open\:hover\:bg-red-200:hover:popover-open {
--tw-bg-opacity: 1;
background-color: rgb(254 202 202 / var(--tw-bg-opacity));
}
.focus\:shadow-md:focus,
.focus\:hover\:shadow-md:hover:focus,
.focus-visible\:shadow-md:focus-visible,
Expand All @@ -274,6 +282,10 @@
--tw-bg-opacity: 1;
background-color: rgb(254 202 202 / var(--tw-bg-opacity));
}
.group:popover-open .group-popover-open\:bg-red-200 {
--tw-bg-opacity: 1;
background-color: rgb(254 202 202 / var(--tw-bg-opacity));
}
.group:default .group-default\:shadow-md,
.group:checked .group-checked\:shadow-md,
.group:indeterminate .group-indeterminate\:shadow-md,
Expand Down Expand Up @@ -335,6 +347,10 @@
--tw-bg-opacity: 1;
background-color: rgb(254 202 202 / var(--tw-bg-opacity));
}
.peer:popover-open ~ .peer-popover-open\:bg-red-200 {
--tw-bg-opacity: 1;
background-color: rgb(254 202 202 / var(--tw-bg-opacity));
}
.peer:default ~ .peer-default\:shadow-md,
.peer:checked ~ .peer-checked\:shadow-md,
.peer:indeterminate ~ .peer-indeterminate\:shadow-md,
Expand Down
4 changes: 4 additions & 0 deletions tests/variants.test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<div class="active:shadow-md"></div>
<div class="target:shadow-md"></div>
<div class="open:bg-red-200"></div>
<div class="popover-open:bg-red-200"></div>
<div class="visited:shadow-md"></div>
<div class="default:shadow-md"></div>
<div class="checked:shadow-md"></div>
Expand Down Expand Up @@ -46,6 +47,7 @@

<!-- Group variants -->
<div class="group-open:bg-red-200"></div>
<div class="group-popover-open:bg-red-200"></div>
<div class="group-first:shadow-md"></div>
<div class="group-last:shadow-md"></div>
<div class="group-only:shadow-md"></div>
Expand Down Expand Up @@ -79,6 +81,7 @@

<!-- Peer variants -->
<div class="peer-open:bg-red-200"></div>
<div class="peer-popover-open:bg-red-200"></div>
<div class="peer-first:shadow-md"></div>
<div class="peer-last:shadow-md"></div>
<div class="peer-only:shadow-md"></div>
Expand Down Expand Up @@ -146,6 +149,7 @@

<!-- Stacked variants -->
<div class="open:hover:bg-red-200"></div>
<div class="popover-open:hover:bg-red-200"></div>
<div class="file:hover:bg-blue-600"></div>
<div class="focus:hover:shadow-md"></div>
<div class="sm:active:shadow-md"></div>
Expand Down