Skip to content

Fixes pack #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes pack #146

wants to merge 3 commits into from
+19 −20

Conversation

brain5lug
Copy link

@pmelkozer
logger: make logger a bit faster
de614f9 
Eliminate copying from std::stringstream if complied with C++20 or higher
@pmelkozer
utils: std::forward related fixes
0d27189 
std::forward were replace std::move for fixed type context where
it does not make sense. Some redundant comment were removed as they
declare obvious actions under them.
@pmelkozer
client: use std::string_view for call function
0401fe1 
For most of cases encoding fuction such as `call`, `execute` and
`prepare` use predefined fixed literal. Those values are best to
be expressed as std::string_view literals.
std::string_view are really usefull and can be easily createad
from any sequense memory areas.
There are no changes are required from cliend side as
std::string_view can be implicilty coverted from std::string.
@sergepetrenko sergepetrenko requested a review from drewdzzz October 6, 2025 11:56
@CuriousGeorgiy CuriousGeorgiy mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdzzz drewdzzz Awaiting requested review from drewdzzz

Assignees

@drewdzzz drewdzzz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brain5lug @drewdzzz @pmelkozer