Temporal: Add tests for PlainMonthDay.from with month and invalid monthCode #4597
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
approved these changes
Oct 13, 2025
| assert.throws(RangeError, () => Temporal.PlainMonthDay.from({ monthCode, day: 17 }), | ||
| `monthCode '${monthCode}' is not valid for ISO 8601 calendar`); | ||
| `monthCode '${monthCode}' is not valid for ISO 8601 calendar (without numeric month)`); | ||
| var plausibleMonth = Number(monthCode.slice(1, 3)) + (monthCode.length - 3); |
There was a problem hiding this comment.
I think I see what the intention of this line is, but 0, 19, 99, 13, and 14 are definitely not valid numeric months in the ISO calendar, so it wouldn't catch the case where the numeric month is valid but the month code isn't.
Maybe that's OK as is, or maybe a possible solution would be to clamp plausibleMonth between 1 and 12?
gibson042
force-pushed
the
2025-10-temporal-plainmonthday-invalid-monthcode-with-month
branch
from
d03a20e to
3f4763e
Compare
gibson042
force-pushed
the
2025-10-temporal-plainmonthday-invalid-monthcode-with-month
branch
from
3f4763e to
ab0c9f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by discussion in Matrix.