Skip to content

Temporal: Add tests for PlainMonthDay.from with month and invalid monthCode #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

Temporal: Add tests for PlainMonthDay.from with month and invalid monthCode #4597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions test/built-ins/Temporal/PlainMonthDay/from/monthcode-invalid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,29 @@ features: [Temporal]

["m1", "M1", "m01"].forEach((monthCode) => {
assert.throws(RangeError, () => Temporal.PlainMonthDay.from({ monthCode, day: 17 }),
`monthCode '${monthCode}' is not well-formed`);
`monthCode '${monthCode}' is not well-formed (without numeric month)`);
assert.throws(RangeError, () => Temporal.PlainMonthDay.from({ month: 1, monthCode, day: 17 }),
`monthCode '${monthCode}' is not well-formed (with numeric month)`);
});

assert.throws(RangeError, () => Temporal.PlainMonthDay.from({ year: 2021, month: 12, monthCode: "M11", day: 17 }),
"monthCode and month conflict");

["M00", "M19", "M99", "M13", "M00L", "M05L", "M13L"].forEach((monthCode) => {
assert.throws(RangeError, () => Temporal.PlainMonthDay.from({ monthCode, day: 17 }),
`monthCode '${monthCode}' is not valid for ISO 8601 calendar`);
`monthCode '${monthCode}' is not valid for ISO 8601 calendar (without numeric month)`);
var monthNumber = Number(monthCode.slice(1, 3)) + (monthCode.length - 3);
assert.throws(
RangeError,
() => Temporal.PlainMonthDay.from({ month: monthNumber, monthCode, day: 17 }),
`monthCode '${monthCode}' is not valid for ISO 8601 calendar (with numeric month)`
);
var clampedMonthNumber = monthNumber < 1 ? 1 : monthNumber > 12 ? 12 : monthNumber;
assert.throws(
RangeError,
() => Temporal.PlainMonthDay.from({ month: clampedMonthNumber, monthCode, day: 17 }),
`monthCode '${monthCode}' is not valid for ISO 8601 calendar (with clamped numeric month)`
);
});

assert.throws(
Expand Down