Skip to content

feat(metrics): Migrate from OpenCensus to OpenTelemetry #9043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(metrics): Migrate from OpenCensus to OpenTelemetry #9043

wants to merge 5 commits into from

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Sep 29, 2025 •
edited by waveywaves
Loading

  • Updated pipelinerunmetrics and taskrunmetrics to use OpenTelemetry instruments (histograms, counters, gauges) for creating and recording metrics.
    Introduced new OpenTelemetry configurations in config/config-observability.yaml for exporters and protocols..
    Rewrote the test suites for pipelinerunmetrics and taskrunmetrics to be compatible with the new OpenTelemetry-based implementation.
  • Updated knative to 1.19

Changes

fixes #8969

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind feature

@khrm
Update to knative 1.19
886ba15 
This upgrades knative to 1.19 and other
dependent dependencies.
@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. labels Sep 29, 2025
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 29, 2025
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/metrics.go 86.7% 68.8% -17.9
pkg/reconciler/pipelinerun/pipelinerun.go 91.6% 91.6% -0.0
pkg/taskrunmetrics/metrics.go 87.3% 72.8% -14.5

khrm added 3 commits September 29, 2025 16:21
@khrm
fix(codegen): Correct JSON tags for streaming lists
0e84083 
The 'hack/update-codegen.sh' script was failing with
'streaming_list_type_json_tags' API rule violations.

This was caused by incorrect JSON tags on list types that prevented
them from being correctly interpreted as streaming lists by the
Kubernetes API.

This commit fixes the following:
- Removes ',omitempty' from the 'Items' field in the v1 and v1beta1
  PipelineRunList structs.
- Adds ',omitempty' to the 'ListMeta' field in the v1beta1
  ResolutionRequestList struct.
@khrm
Remove old metrics code from watcher
26a3d1e 
This isn't supported after knative otel's migration.
@khrm
Remove opencensus related vendored code
84a1b3f
@khrm khrm force-pushed the mig-otel branch 2 times, most recently from bab5a44 to a2ea129 Compare September 29, 2025 10:53
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/metrics.go 86.7% 68.8% -17.9
pkg/reconciler/pipelinerun/pipelinerun.go 91.6% 91.6% -0.0
pkg/taskrunmetrics/metrics.go 87.3% 72.8% -14.5

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/metrics.go 86.7% 68.8% -17.9
pkg/reconciler/pipelinerun/pipelinerun.go 91.6% 91.6% -0.0
pkg/taskrunmetrics/metrics.go 87.3% 72.8% -14.5

@waveywaves
Copy link
Member

/retest

@waveywaves waveywaves mentioned this pull request Sep 29, 2025
Closed
8 tasks
@waveywaves waveywaves self-assigned this Sep 29, 2025
@khrm
feat(metrics): Migrate from OpenCensus to OpenTelemetry
4b5feb5 
- Updated `pipelinerunmetrics` and `taskrunmetrics` to use OpenTelemetry instruments (histograms, counters, gauges) for creating and recording metrics.
Introduced new OpenTelemetry configurations in `config/config-observability.yaml` for exporters and protocols, while marking legacy OpenCensus settings as deprecated.
Rewrote the test suites for `pipelinerunmetrics` and `taskrunmetrics` to be compatible with the new OpenTelemetry-based implementation.
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from waveywaves after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/metrics.go 86.7% 68.8% -17.9
pkg/reconciler/pipelinerun/pipelinerun.go 91.6% 91.6% -0.0
pkg/taskrunmetrics/metrics.go 87.3% 72.8% -14.5

@waveywaves
Copy link
Member

/retest

@vdemeester vdemeester added this to the v1.7.0 milestone Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop Awaiting requested review from jerop

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@waveywaves waveywaves

Labels
kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Todo
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Drop use of knative.dev/pkg/metrics
4 participants
@khrm @tekton-robot @waveywaves @vdemeester