Skip to content

feat(metrics): Migrate from OpenCensus to OpenTelemetry #9043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(metrics): Migrate from OpenCensus to OpenTelemetry #9043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
886ba15
Update to knative 1.19
khrm Sep 28, 2025
0e84083
fix(codegen): Correct JSON tags for streaming lists
khrm Sep 29, 2025
26a3d1e
Remove old metrics code from watcher
khrm Sep 28, 2025
84a1b3f
Remove opencensus related vendored code
khrm Sep 28, 2025
4b5feb5
feat(metrics): Migrate from OpenCensus to OpenTelemetry
khrm Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 0 additions & 8 deletions cmd/webhook/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,12 +244,6 @@ func main() {
webhookName = "webhook.pipeline.tekton.dev"
}

var statsReporterOptions []webhook.StatsReporterOption
enableNamespace := os.Getenv("WEBHOOK_METRICS_ENABLE_NAMESPACE")
if enableNamespace != "true" {
statsReporterOptions = append(statsReporterOptions, webhook.WithoutTags("resource_namespace"))
}

// Scope informers to the webhook's namespace instead of cluster-wide
ctx := injection.WithNamespaceScope(signals.NewContext(), system.Namespace())

Expand All @@ -258,8 +252,6 @@ func main() {
ServiceName: serviceName,
Port: webhook.PortFromEnv(8443),
SecretName: secretName,

StatsReporterOptions: statsReporterOptions,
})

mux := http.NewServeMux()
Expand Down
8 changes: 0 additions & 8 deletions config/300-crds/300-pipelinerun.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,6 @@ spec:
- Ignore: nodeAffinity/nodeSelector are ignored. All nodes are included in the calculations.

If this value is nil, the behavior is equivalent to the Honor policy.
This is a beta-level feature default enabled by the NodeInclusionPolicyInPodTopologySpread feature flag.
type: string
nodeTaintsPolicy:
description: |-
Expand All @@ -565,7 +564,6 @@ spec:
- Ignore: node taints are ignored. All nodes are included.

If this value is nil, the behavior is equivalent to the Ignore policy.
This is a beta-level feature default enabled by the NodeInclusionPolicyInPodTopologySpread feature flag.
type: string
topologyKey:
description: |-
Expand Down Expand Up @@ -1363,7 +1361,6 @@ spec:
- Ignore: nodeAffinity/nodeSelector are ignored. All nodes are included in the calculations.

If this value is nil, the behavior is equivalent to the Honor policy.
This is a beta-level feature default enabled by the NodeInclusionPolicyInPodTopologySpread feature flag.
type: string
nodeTaintsPolicy:
description: |-
Expand All @@ -1374,7 +1371,6 @@ spec:
- Ignore: node taints are ignored. All nodes are included.

If this value is nil, the behavior is equivalent to the Ignore policy.
This is a beta-level feature default enabled by the NodeInclusionPolicyInPodTopologySpread feature flag.
type: string
topologyKey:
description: |-
Expand Down Expand Up @@ -3706,7 +3702,6 @@ spec:
- Ignore: nodeAffinity/nodeSelector are ignored. All nodes are included in the calculations.

If this value is nil, the behavior is equivalent to the Honor policy.
This is a beta-level feature default enabled by the NodeInclusionPolicyInPodTopologySpread feature flag.
type: string
nodeTaintsPolicy:
description: |-
Expand All @@ -3717,7 +3712,6 @@ spec:
- Ignore: node taints are ignored. All nodes are included.

If this value is nil, the behavior is equivalent to the Ignore policy.
This is a beta-level feature default enabled by the NodeInclusionPolicyInPodTopologySpread feature flag.
type: string
topologyKey:
description: |-
Expand Down Expand Up @@ -4349,7 +4343,6 @@ spec:
- Ignore: nodeAffinity/nodeSelector are ignored. All nodes are included in the calculations.

If this value is nil, the behavior is equivalent to the Honor policy.
This is a beta-level feature default enabled by the NodeInclusionPolicyInPodTopologySpread feature flag.
type: string
nodeTaintsPolicy:
description: |-
Expand All @@ -4360,7 +4353,6 @@ spec:
- Ignore: node taints are ignored. All nodes are included.

If this value is nil, the behavior is equivalent to the Ignore policy.
This is a beta-level feature default enabled by the NodeInclusionPolicyInPodTopologySpread feature flag.
type: string
topologyKey:
description: |-
Expand Down
48 changes: 36 additions & 12 deletions config/300-crds/300-task.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ spec:
Cannot be updated.
type: array
items:
description: EnvFromSource represents the source of a set of ConfigMaps
description: EnvFromSource represents the source of a set of ConfigMaps or Secrets
type: object
properties:
configMapRef:
Expand All @@ -443,7 +443,7 @@ spec:
type: boolean
x-kubernetes-map-type: atomic
prefix:
description: An optional identifier to prepend to each key in the ConfigMap. Must be a C_IDENTIFIER.
description: Optional text to prepend to the name of each environment variable. Must be a C_IDENTIFIER.
type: string
secretRef:
description: The Secret to select from
Expand Down Expand Up @@ -689,6 +689,12 @@ spec:
- type: integer
- type: string
x-kubernetes-int-or-string: true
stopSignal:
description: |-
StopSignal defines which signal will be sent to a container when it is being stopped.
If not specified, the default is defined by the container runtime in use.
StopSignal can only be set for Pods with a non-empty .spec.os.name
type: string
livenessProbe:
description: |-
Periodic probe of Sidecar liveness.
Expand Down Expand Up @@ -1781,7 +1787,7 @@ spec:
Cannot be updated.
type: array
items:
description: EnvFromSource represents the source of a set of ConfigMaps
description: EnvFromSource represents the source of a set of ConfigMaps or Secrets
type: object
properties:
configMapRef:
Expand All @@ -1802,7 +1808,7 @@ spec:
type: boolean
x-kubernetes-map-type: atomic
prefix:
description: An optional identifier to prepend to each key in the ConfigMap. Must be a C_IDENTIFIER.
description: Optional text to prepend to the name of each environment variable. Must be a C_IDENTIFIER.
type: string
secretRef:
description: The Secret to select from
Expand Down Expand Up @@ -2052,6 +2058,12 @@ spec:
- type: integer
- type: string
x-kubernetes-int-or-string: true
stopSignal:
description: |-
StopSignal defines which signal will be sent to a container when it is being stopped.
If not specified, the default is defined by the container runtime in use.
StopSignal can only be set for Pods with a non-empty .spec.os.name
type: string
livenessProbe:
description: |-
Periodic probe of container liveness.
Expand Down Expand Up @@ -3107,7 +3119,7 @@ spec:
Cannot be updated.
type: array
items:
description: EnvFromSource represents the source of a set of ConfigMaps
description: EnvFromSource represents the source of a set of ConfigMaps or Secrets
type: object
properties:
configMapRef:
Expand All @@ -3128,7 +3140,7 @@ spec:
type: boolean
x-kubernetes-map-type: atomic
prefix:
description: An optional identifier to prepend to each key in the ConfigMap. Must be a C_IDENTIFIER.
description: Optional text to prepend to the name of each environment variable. Must be a C_IDENTIFIER.
type: string
secretRef:
description: The Secret to select from
Expand Down Expand Up @@ -3376,6 +3388,12 @@ spec:
- type: integer
- type: string
x-kubernetes-int-or-string: true
stopSignal:
description: |-
StopSignal defines which signal will be sent to a container when it is being stopped.
If not specified, the default is defined by the container runtime in use.
StopSignal can only be set for Pods with a non-empty .spec.os.name
type: string
livenessProbe:
description: |-
Periodic probe of container liveness.
Expand Down Expand Up @@ -4834,7 +4852,7 @@ spec:
Cannot be updated.
type: array
items:
description: EnvFromSource represents the source of a set of ConfigMaps
description: EnvFromSource represents the source of a set of ConfigMaps or Secrets
type: object
properties:
configMapRef:
Expand All @@ -4855,7 +4873,7 @@ spec:
type: boolean
x-kubernetes-map-type: atomic
prefix:
description: An optional identifier to prepend to each key in the ConfigMap. Must be a C_IDENTIFIER.
description: Optional text to prepend to the name of each environment variable. Must be a C_IDENTIFIER.
type: string
secretRef:
description: The Secret to select from
Expand Down Expand Up @@ -5101,6 +5119,12 @@ spec:
- type: integer
- type: string
x-kubernetes-int-or-string: true
stopSignal:
description: |-
StopSignal defines which signal will be sent to a container when it is being stopped.
If not specified, the default is defined by the container runtime in use.
StopSignal can only be set for Pods with a non-empty .spec.os.name
type: string
livenessProbe:
description: |-
Periodic probe of Sidecar liveness.
Expand Down Expand Up @@ -6191,7 +6215,7 @@ spec:
Cannot be updated.
type: array
items:
description: EnvFromSource represents the source of a set of ConfigMaps
description: EnvFromSource represents the source of a set of ConfigMaps or Secrets
type: object
properties:
configMapRef:
Expand All @@ -6212,7 +6236,7 @@ spec:
type: boolean
x-kubernetes-map-type: atomic
prefix:
description: An optional identifier to prepend to each key in the ConfigMap. Must be a C_IDENTIFIER.
description: Optional text to prepend to the name of each environment variable. Must be a C_IDENTIFIER.
type: string
secretRef:
description: The Secret to select from
Expand Down Expand Up @@ -6746,7 +6770,7 @@ spec:
Cannot be updated.
type: array
items:
description: EnvFromSource represents the source of a set of ConfigMaps
description: EnvFromSource represents the source of a set of ConfigMaps or Secrets
type: object
properties:
configMapRef:
Expand All @@ -6767,7 +6791,7 @@ spec:
type: boolean
x-kubernetes-map-type: atomic
prefix:
description: An optional identifier to prepend to each key in the ConfigMap. Must be a C_IDENTIFIER.
description: Optional text to prepend to the name of each environment variable. Must be a C_IDENTIFIER.
type: string
secretRef:
description: The Secret to select from
Expand Down
Loading
Loading