Repository navigation
Add Required PR Checks job to gate merges - #3162
Open
cconstable wants to merge 2 commits into
Open
cconstable wants to merge 2 commits into
cconstable wants to merge 2 commits into
Conversation
cconstable
marked this pull request as ready for review
October 21, 2026 19:30
cconstable
commented
Oct 21, 2026
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
|
|
||
| features-test: |
Contributor
Author
There was a problem hiding this comment.
Moved the features tests into here so it can be referenced by the needs: block of the required_pr_checks. One small change is that the features checks now run consistently with the rest of the checks (on main and on PRs) instead of just on push and on PRs which makes sense to me.
Quinn-With-Two-Ns
approved these changes
Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Required PR Checksjob to ci.yml. It runs after the jobs that are required to merge today and fails if any of them failed or was cancelled.features-testfrom features.yml into ci.yml, since a job can only wait on jobs in its own file. Features tests now run on PRs and pushes tomain, no longer on pushes to every branch.Why?
Branch protection lists required checks by exact name, so CI changes also need a branch protection change made at the same moment. With one roll-up job, those changes only touch this repo. Branch protection will be switched to require only
Required PR Checksafter this merges.