Skip to content

Add Required PR Checks job to gate merges #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cconstable wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Required PR Checks job to gate merges #3162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3851a2
Add Required PR Checks job to gate merges
cconstable Oct 21, 2026
84e5b92
Merge branch 'main' into java-required-checks
cconstable Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,3 +254,31 @@ jobs:
uses: ./.github/workflows/build-native-image.yml
with:
ref: ${{ github.event.pull_request.head.sha }}

features-test:

@cconstable cconstable Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the features tests into here so it can be referenced by the needs: block of the required_pr_checks. One small change is that the features checks now run consistently with the rest of the checks (on main and on PRs) instead of just on push and on PRs which makes sense to me.

permissions:
contents: read
actions: read
uses: temporalio/features/.github/workflows/java.yaml@main
with:
java-repo-path: ${{github.event.pull_request.head.repo.full_name}}
version: ${{github.event.pull_request.head.ref}}
version-is-repo-ref: true

# The single required status check for merging: a PR can merge only if every job in
# `needs` passed.
required_pr_checks:
name: Required PR Checks
# Without always(), this job would be skipped when a dependency fails, and GitHub
# treats a skipped required check as passing.
if: always()
needs:
- unit_test_edge
- unit_test_jdk8
- code_format
- features-test
runs-on: ubuntu-latest
steps:
- name: Fail if any check failed or was cancelled
if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}
run: exit 1
13 changes: 0 additions & 13 deletions .github/workflows/features.yml
View file
Open in desktop

This file was deleted.

Loading