Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project GUID to Foundation.UUID #134

Merged
merged 2 commits into from
Jan 18, 2024
Merged

project GUID to Foundation.UUID #134

merged 2 commits into from
Jan 18, 2024

Conversation

stevenbrix
Copy link
Collaborator

We don't fully qualify the GUID type in ReferenceWrapper which leads to issues since the types in WinSDK are implicitly imported.

This PR projects GUID to Foundation.UUID and also ensure that we write the Foundation.UUID typename, which fixes this problem

Fixes #130

@stevenbrix stevenbrix requested a review from a team as a code owner January 18, 2024 23:39
@stevenbrix stevenbrix changed the title project guid to UUID project GUID to Foundation.UUID Jan 18, 2024
@stevenbrix stevenbrix merged commit 7e42cb0 into main Jan 18, 2024
1 check passed
@stevenbrix stevenbrix deleted the steve/project-guid-to-uuid branch January 18, 2024 23:52
@stevenbrix stevenbrix mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumhyn-browser jumhyn-browser jumhyn-browser approved these changes

@jeffdav jeffdav jeffdav approved these changes

@tristanlabelle tristanlabelle Awaiting requested review from tristanlabelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation errors when generating sources for Microsoft.UI.Xaml.Controls.WebView2
3 participants
@stevenbrix @jeffdav @jumhyn-browser