Skip to content

Conversation

@adamlazik1
Copy link
Contributor

@adamlazik1 adamlazik1 commented Oct 24, 2025

#10370 removed the method limited?, so it should be replaced here.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a bugfix for https://projects.theforeman.org/issues/37987, could use you Refs #37987 on this PR?

@adamlazik1 adamlazik1 force-pushed the remove-undefined-method branch from fe54d6a to 6bb0a9f Compare October 24, 2025 09:45
@adamlazik1 adamlazik1 changed the title Replace undefined method Refs #37987 - Replace undefined method Oct 24, 2025
@adamlazik1
Copy link
Contributor Author

Thanks @ekohl, done.

@ekohl
Copy link
Member

ekohl commented Oct 24, 2025

There's a typo in should in the commit message.

theforeman#10370 removed the method
`limited?`, so it should be replaced here.
@adamlazik1 adamlazik1 force-pushed the remove-undefined-method branch from 6bb0a9f to 24e9d1d Compare October 24, 2025 09:52
@adamlazik1
Copy link
Contributor Author

There's a typo in should in the commit message.

Fixed.

@stejskalleos stejskalleos merged commit d59fd78 into theforeman:develop Nov 7, 2025
58 of 60 checks passed
@stejskalleos
Copy link
Contributor

Thanks @adamlazik1

@adamlazik1 adamlazik1 deleted the remove-undefined-method branch November 7, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants