Fix tests #1068
Merged
Fix tests #1068
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
Jan 5, 2026
Gemfile
Outdated
Comment on lines
13
to
15
| if RUBY_VERSION >= '3.2' | ||
| gem 'minitest-mock' # minitest-mock was removed from minitest 6.0 which is Ruby 3.2+ | ||
| end |
Member
Author
There was a problem hiding this comment.
This is ugly and I think it's easier to pin minitest to ~> 5.0 for now
ekohl
reviewed
Jan 5, 2026
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
👍 for pinning to minitest 5 for now.
|
|
||
| it 'has no config file' do | ||
| _(subject.config_file).must_equal(nil) | ||
| _(subject.config_file).must_be_nil |
Member
There was a problem hiding this comment.
I've been leaning to using the assert_* statements more because IMHO they're easier to read. So instead go with:
Suggested change
| _(subject.config_file).must_be_nil | |
| assert_nil subject.config_file |
But that's rather inconsistent with the rest of the file
Member
Author
There was a problem hiding this comment.
That's why I didn't change it like this :)
- 6.x splits out Minitest::Mock into an own gem: minitest-mock - 6.x requires Ruby 3.2 - minitest-mock requires Ruby 3.1 As we need to keep Ruby 3.0 compatibility, we can't depend on minitest-mock unconditionally. Let's keep us on minitest 5.x for now
Member
Author
|
Technically we can skip changing the |
ekohl
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.