Skip to content

Fix tests #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekohl merged 2 commits into from
Jan 5, 2026
Merged

Fix tests #1068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da8ed53
Use `must_be_nil` instead of `must_equal nil`
evgeni Jan 5, 2026
c3f7f00
Pin minitest to 5.x
evgeni Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion foreman_maintain.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ the Foreman/Satellite up and running."
s.add_dependency 'highline'

s.add_development_dependency 'bundler', '>= 1.17'
s.add_development_dependency 'minitest'
s.add_development_dependency 'minitest', '~> 5.0'
s.add_development_dependency 'minitest-reporters'
s.add_development_dependency 'minitest-stub-const'
s.add_development_dependency 'mocha'
Expand Down
2 changes: 1 addition & 1 deletion test/definitions/features/installer_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
end

it 'has no config file' do
_(subject.config_file).must_equal(nil)
_(subject.config_file).must_be_nil
Copy link
Member

@ekohl ekohl Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been leaning to using the assert_* statements more because IMHO they're easier to read. So instead go with:

Suggested change
_(subject.config_file).must_be_nil
assert_nil subject.config_file

But that's rather inconsistent with the rest of the file

Copy link
Member Author

@evgeni evgeni Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I didn't change it like this :)

end
end
end
2 changes: 1 addition & 1 deletion test/lib/cli/plugin_command_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ module ForemanMaintain

it 'runs purge-puppet' do
Cli::PluginCommand.any_instance.expects(:run_scenario).with do |scenario|
_(scenario.context.get(:remove_data)).must_equal nil
_(scenario.context.get(:remove_data)).must_be_nil
_(scenario.label).must_equal :puppet_disable
end
run_cmd
Expand Down