correctly set X-FORWARDED-PROTO header #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Tests are not happy, but this is indeed needed. |
Member
Author
|
there you go, now CI should be happy again with me |
ekohl
reviewed
Feb 20, 2025
| <Location "/pulp/api/v3"> | ||
| RequestHeader unset REMOTE-USER | ||
| RequestHeader unset REMOTE_USER | ||
| RequestHeader set X-FORWARDED-PROTO expr=%{REQUEST_SCHEME} |
Member
There was a problem hiding this comment.
Looking at the lines above, do we need to unset the underscore variations?
Member
Author
There was a problem hiding this comment.
of forwarded proto? modern gunicorn will reject it anyway, so I'd skip it.
Member
There was a problem hiding this comment.
I thought so too, but it looked inconsistent with the above.
ekohl
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.