Use pulpcore-worker entrypoint directly, without a wrapper #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since pulpcore 3.13 the worker has an own "binary" (Python entrypoint),
that is correctly labeled as pulpcore_exec_t (since pulpcore-selinux
2.0.1) and thus the workaround with an wrapper is not necessary anymore.
It's actually harmful, as the wrapper is labeled pulpcore_exec_t, so on
execution it auto-transitions into pulpcore_t, but then it wants to
execute /usr/bin/pulpcore-worker, which is again pulpcore_exec_t but
pulpcore_t is not allowed to transition to pulpcore_exec_t and you get
denied { execute_no_trans } for comm="pulpcore-worker" path="/usr/bin/pulpcore-worker" scontext=system_u:system_r:pulpcore_t:s0 tcontext=system_u:object_r:pulpcore_exec_t:s0 tclass=file
Fixes: 137128e
ekohl
approved these changes
Jun 24, 2025
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
On my phone so harder to check. What creates the libexec wrapper? Should we clean those up too?
Member
Author
|
The packaging, will clean up there later, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pulpcore 3.13 the worker has an own "binary" (Python entrypoint), that is correctly labeled as pulpcore_exec_t (since pulpcore-selinux 2.0.1) and thus the workaround with an wrapper is not necessary anymore.
It's actually harmful, as the wrapper is labeled pulpcore_exec_t, so on execution it auto-transitions into pulpcore_t, but then it wants to execute /usr/bin/pulpcore-worker, which is again pulpcore_exec_t but pulpcore_t is not allowed to transition to pulpcore_exec_t and you get
Fixes: 137128e