Skip to content

fix(a11y): accessibility fixes - #543

Open
Clupai8o0 wants to merge 3 commits into
thoth-tech:11.0.xfrom
ontrack-features-t2-2026:upstream-pr/a11y
Open

Clupai8o0 wants to merge 3 commits into
thoth-tech:11.0.xfrom
ontrack-features-t2-2026:upstream-pr/a11y

Conversation

@Clupai8o0

@Clupai8o0 Clupai8o0 commented Sep 27, 2026 •

Copy link
Copy Markdown

What this is

This is the team's accessibility work across student and staff screens. It turns on four template lint rules for keyboard and label access and fixes the templates they flagged. It adds names, labels and live status regions for screen readers, darkens task status colours for contrast, and skips confetti when the user asks for reduced motion.

What is in it

  • eslint.config.js: turns on the four template rules, stops ignoring .tpl.html files and reports unused disable comments. Six old .tpl.html templates are removed.
  • src/app/units/states/tasks/inbox/: labelled filters and rows, status regions, empty states and phone actions in the staff task list and inbox.
  • Task comments, comment actions, grade and moderation dialogs, and tutor and staff notes: real buttons with names and labels.
  • Forms across unit admin, the date slider, the learning outcome editor and sign-in: labels tied to their controls, and autocomplete hints on sign-in.
  • src/app/api/models/task-status.ts: darker status colours. Because the file is shared, it also carries the peer progress display order.
  • src/app/common/services/confetti.service.ts: respects reduced motion.
  • src/app/common/testing/accessibility.ts: an axe-core helper for rendered checks. 15 new spec files and 4 updated.
  • docs/accessibility/ and docs/A11Y-D01-Accessibility-Baseline_Phase1.md: the baseline, an authoring guide, and regression and remediation notes.
  • One more commit, "feat(theme): page redesign for the a11y files", brings the page redesign to 44 of this PR's files (11 of them specs). It comes from feat(theme): reland dark mode and the page redesign on 11.0.x ontrack-features-t2-2026/doubtfire-web#280, merged into our org 11.0.x on 27 Sep 2026. The rest of the redesign is feat(theme): page redesign and dark mode for every page #545.
  • Update, 28 Sep 2026: one more commit. Brings feat: land integration/t2-2026 (panels, notification links, a11y, Unit Hub rework) ontrack-features-t2-2026/doubtfire-web#281. It carries the accessible name and contrast fixes, the restyled About dialog and the tidier status picker.

How this set of PRs works

This is one of 24 PRs from the Thoth Tech T2 2026 Features team (9 api, 14 web, 1 deploy), one per feature per repo. Each one carries that feature's files, taken from our team org's 11.0.x branch, and applied straight onto thoth-tech 11.0.x. Every file is in exactly one PR. Some files are shared between features, so a PR on its own may not build. The demo PR in each repo (api #127, web #544) is imported by earlier PRs too, so it has to go in with the rest, not be dropped. Merged in the order below, the set equals our org 11.0.x minus team docs, evidence files, org-only CI and dev setup files. No app code or tests are left out.

On 28 Sep 2026 the set was brought up to our org's latest merges (api ontrack-features-t2-2026/doubtfire-api#178, web ontrack-features-t2-2026#281 and ontrack-features-t2-2026#282, deploy ontrack-features-t2-2026/doubtfire-deploy#41). Most PRs got one more commit for that. Two web PRs are new, panels (#546) and celebrate (#547), for files that were in no PR before.

Merge order, api first, then web, then deploy. In web, panels goes before the pages that use it, and celebrate goes after a11y, whose confetti service it needs.

Built against

  • api: thoth-tech 11.0.x @ dc76a5a0e, taken from org 11.0.x @ a9589b302
  • web: thoth-tech 11.0.x @ 20d1f380c, taken from org 11.0.x @ 0b8a20344
  • deploy: thoth-tech 11.0.x @ 58905969e, taken from org 11.0.x @ 8e560f7e0

Testing

Checked on 28 Sep 2026 with all the branches merged together. This PR was not tested on its own, see above.

  • web: with all 14 web branches merged onto thoth-tech 11.0.x, npm run test:ci runs 2603 tests in 290 files, all passing, and npm run lint and ng build pass. The merged set's app code is the same as our org 11.0.x after fix(profile): save a changed summary email cadence ontrack-features-t2-2026/doubtfire-web#282, where CI passed test, lint (22) and build (22).
  • api: the full Minitest suite passes on the nine api PRs merged onto thoth-tech 11.0.x. 1799 tests, 20182 assertions, 0 failures, 0 errors, 0 skips. It ran through our CI on branch check/upstream-combined-28sep (run), and the database schema check and RuboCop pass there too. The set differs from our org 11.0.x only by the left-out docs, evidence, CI and dev setup files, none of them app code.
  • deploy: production/tests/validate_test.sh, verify_pwa_test.py, publish_release_test.py and nginx_upload_test.py pass. The production compose file loads with docker compose config against .env.production.example, and the development and .devcontainer ones load as they are.

Contributors

Samridh Limbu, Maple Fox, Kimsreng, baohuy-tran, Thirus224849242, Tan Tai, Swyam Khare, SanjanaBottu, sakethsram888, Niethin Shreedharan, Gaurav Myana, Freddy, Eloise Ridder-Strickland

Brings the T2 2026 a11y work from ontrack-features-t2-2026 11.0.x (reviewed and merged work) onto thoth-tech 11.0.x.

Co-authored-by: maplefoxgit <s223932052@deakin.edu.au>
Co-authored-by: Maple Fox <s223932052@deakin.edu.au>
Co-authored-by: Kimsreng <kimsrengin@gmail.com>
Co-authored-by: baohuy-tran <baohuy.tranaus@gmail.com>
Co-authored-by: Thirus224849242 <s224849242@deakin.edu.au>
Co-authored-by: Tan Tai <s224621011@deakin.edu.au>
Co-authored-by: Swyam Khare <s223759285@deakin.edu.au>
Co-authored-by: SanjanaBottu <bottusanjanasridhar@gmail.com>
Co-authored-by: sakethsram888 <s225092561@deakin.edu.au>
Co-authored-by: Niethin <niethinrueshil@gmail.com>
Co-authored-by: Gaurav Myana <s225108954@deakin.edu.au>
Co-authored-by: Freddy <zhiyi9043@gmail.com>
Co-authored-by: Eloise Ridder-Strickland <eloise.ridderstrickland@gmail.com>
Brings the dark mode page redesign (#280, which relands
#192)
to the files this PR already carries, so every file stays in exactly one PR.

Co-authored-by: Maple Fox <s223932052@deakin.edu.au>
Brings #281 to the files this PR
already carries, so every file stays in exactly one PR. It carries the
accessible name and contrast fixes, the restyled About dialog and the
tidier status picker.

Co-authored-by: Maple Fox <s223932052@deakin.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants