Fix qos_net's CLI to build correctly without default features #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cr-tk
approved these changes
Feb 27, 2025
andrewkmin
approved these changes
Feb 28, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
Discovered by @cr-tk in #502
This change introduces a no-op qos_net CLI when the default "proxy" feature isn't enabled. The CLI simply panics because there is nothing to do: the CLI is the way to start the proxy, and does not make sense without the proxy feature.
How I Tested These Changes
On this branch,
cargo build --locked --no-default-features --releasesucceeds.