Revert Manage Themes dialog group/theme name input change #2883
Conversation
|
| @@ -175,7 +178,7 @@ export const CreateOrEditThemeForm: React.FC<React.PropsWithChildren<React.Props | |||
| )} | |||
| <Stack direction="column" gap={1}> | |||
| {activeTab === ThemeFormTabs.SETS && ( | |||
| <Stack direction="column" gap={1} css={{ padding: '0 $4 $3' }}> | |||
| <Stack direction="column" gap={1} css={{ padding: '$3 $4 $3' }}> | |||
There was a problem hiding this comment.
Adds a little spacing so the group buttons aren't touching the 1px border line.
| @@ -118,6 +117,7 @@ export const CreateOrEditThemeForm: React.FC<React.PropsWithChildren<React.Props | |||
| autofocus | |||
| data-testid="create-or-edit-theme-form--group--name" | |||
| {...register('group')} | |||
| placeholder="Add group" | |||
There was a problem hiding this comment.
Maybe use createNewGroup as it's a translated string? Or anything similar.
| full | ||
| data-testid="create-or-edit-theme-form--input--name" | ||
| {...register('name', { required: true })} | ||
| placeholder="Theme name" |
There was a problem hiding this comment.
Similar comment about this placeholder being a translated string if possible
| variant="secondary" | ||
| icon={<IconPlus />} | ||
| size="small" | ||
| css={{ display: 'flex', alignItems: 'center', height: '28px' }} |
There was a problem hiding this comment.
| css={{ display: 'flex', alignItems: 'center', height: '28px' }} | |
| css={{ display: 'flex', alignItems: 'center', height: $controlMedium }} |
There was a problem hiding this comment.
Actually, none of this CSS is needed? Just tried disabling it and there's other styling that takes over, and is the same as this.
|
@macintoshhelper would you want to make these changes in a follow-up PR? I'll merge this in for rc8 given the requested changes dont change behavior too much 👍 |
Why does this PR exist?
Fixes #2880
What does this pull request do?
Testing this change
Theme: NoneorTheme: {theme_name_here}Manage Themes+ New ThemebuttonAdditional Notes (if any)
Add groupandTheme name