Introduce Await component for nicer template usage
#709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing `load` function/helper combo gets the job done, but this
new component has a similar top-level API but requires no `if`-based
branching. Instead, it uses named blocks to render the resulting state.
import { Async } from 'ember-async-data';
<template>
<Async @DaTa={{Promise.resolve 123}}>
<:pending>Still waiting...</:pending>
<:resolved as |value|>
The value is: {{value}}.
</:resolved>
<:rejected>Whoops! Something went wrong!</:rejected>
</Async>
</template>
This ends up being both briefer *and* less error prone, not least since
it provides the resolved value automatically from the `resolved` block,
whereas expressly checking `{{#if someAsyncData.isResolved}}` *allowed*
the further `{{someAsyncData.value}}` access but did not provide it
automatically.
chriskrycho
commented
Sep 12, 2023
There was a problem hiding this comment.
This seemed to be the best approach we had when I spiked this out a few months ago, but I'm totally up for a different approach if we have something better now.
There was a problem hiding this comment.
the v2 addon blueprint, via @embroider/addon-dev does this for you now.
However, pending:
- Glint does not support gts imports with the extension embroider-build/addon-blueprint#194
- gts files are left with side-effecting imports embroider-build/addon-blueprint#195
I use this for now:
https://github.com/universal-ember/ember-primitives/blob/main/ember-primitives/rollup.config.mjs#L20
NullVoxPopuli
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
loadfunction/helper combo gets the job done, but this new component has a similar top-level API but requires noif-based branching. Instead, it uses named blocks to render the resulting states.This ends up being both briefer and less error prone, not least since it provides the resolved value automatically from the
resolvedblock, whereas expressly checking{{#if someAsyncData.isResolved}}allowed the further{{someAsyncData.value}}access but did not provide it automatically.