feat: add defaultAsBreadcrumb option #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, all logs are sent by default to Sentry, unless we explictly pass
true
toasBreadcrumb
to the logger method. This is impractical, and also causes issues for framework level log (such as nestjs route explorer).Solution
Introduce a non-breaking
defaultAsBreadcrumb
option. It takes in a non-error level log array to define which method should default to breadcrumb (in opposition to capturing an event)Example Usage
Caveats
The
SentryServiceInstance
method returns a newSentryService
in which the options are undefined. To fix, it was necessary to set the instance in the constructor (when the options have been specified). This seems to work well but unsure of any side-effects within the package