Skip to content

Conversation

@gmondada
Copy link

In ChromeRTCPeerConnection, getRemoteStreams is a property copied from RTCPeerConnection. When calling getRemoteStreams(), this method is invoked with ChromeRTCPeerConnection instance as this. The call is forwarded to RTCPeerConnection with the same this, which works but is not correct.

@gmondada
Copy link
Author

Actually, I don't know if somewhere in the WebRTC API doc or in any JS API in general we clearly define what value this has to have when invoking a method. It seems here the this is ignored.

@markandrus
Copy link
Contributor

markandrus commented Oct 4, 2018

Hi @gmondada,

What are you using this for? Or how does this cause problems for you?

@gmondada
Copy link
Author

gmondada commented Oct 4, 2018

I was trying to use an RTCPeerConnection proxy which forwards all calls to the real RTCPeerConnection. This allows me to log some info as the video and audio codecs in use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants