Skip to content

fix RTCPeerConnection.getRemoteStreams() called with the wrong value of this #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmondada wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix RTCPeerConnection.getRemoteStreams() called with the wrong value of this #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed36997
fix chrome implementation which called RTCPeerConnection.getRemoteStr…
gmondada Sep 11, 2018
ec16136
fake package version number
gmondada Oct 3, 2018
1cc0f62
fix ChromeRTCPeerConnection which does not proxy inherited properties
gmondada Dec 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion lib/rtcpeerconnection/chrome.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,18 @@ function ChromeRTCPeerConnection(configuration, constraints) {
};

peerConnection.addStream(this._localStream);
util.proxyProperties(PeerConnection.prototype, this, peerConnection);

/*
* In Chrome's RTCPeerConnection class all methods and properties are
* non-inherited, but other implementaitons could implement RTCPeerConnection
* by inheriting EventTarget or other classes. So, we go through all
* super-classes
*/
var propList = Object.getPrototypeOf(peerConnection);
do {
util.proxyProperties(propList, this, peerConnection);
propList = Object.getPrototypeOf(propList);
} while (propList != null);
}

inherits(ChromeRTCPeerConnection, EventTarget);
Expand Down Expand Up @@ -320,6 +331,14 @@ ChromeRTCPeerConnection.prototype.setRemoteDescription = function setRemoteDescr
: promise;
};

ChromeRTCPeerConnection.prototype.getLocalStreams = function getLocalStreams() {
return this._peerConnection.getLocalStreams();
}

ChromeRTCPeerConnection.prototype.getRemoteStreams = function getRemoteStreams() {
return this._peerConnection.getRemoteStreams();
}

util.delegateMethods(
PeerConnection.prototype,
ChromeRTCPeerConnection.prototype,
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "@twilio/webrtc",
"version": "3.0.1-dev",
"__version": "3.0.1-dev",
"version" : "2.1.3",
"description": "WebRTC-related APIs and shims used by twilio-video.js",
"scripts": {
"build": "npm-run-all clean lint test",
Expand Down