Test fixes #808
Merged
Test fixes #808
+69
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@cecilialau6776 Thanks! Can you please squash into single commit. |
cecilialau6776
force-pushed
the
test_fixes
branch
2 times, most recently
from
8334d4b to
f35a961
Compare
Contributor
Author
|
Yup! Squashed and rebased. |
aebruno
requested changes
Oct 21, 2025
coldfront/core/project/forms.py
Outdated
| USERNAME = "Username" | ||
| FIELD_OF_SCIENCE = "Field of Science" | ||
|
|
||
| last_name = forms.CharField(label=TITLE, max_length=255, required=False) |
Member
There was a problem hiding this comment.
Can you double check the variable name here. Should this be title?
Contributor
Author
There was a problem hiding this comment.
Yes, you're right! Thanks for the catch :)
cecilialau6776
force-pushed
the
test_fixes
branch
from
f35a961 to
2b4b610
Compare
Squashed commits: - fix project view tests - fix allocation change view tests - fix ProjectListViewTest.test_project_list_search and add title to project search - fix allocation expiry tests - replaced `timezone.now()` calls in test_models.py with `datetime.date.now()`, since that's what the model uses Signed-off-by: Cecilia Lau <[email protected]>
cecilialau6776
force-pushed
the
test_fixes
branch
from
2b4b610 to
55364cb
Compare
aebruno
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some tests
ProjectUserDetailexpects aProjectUserpk, but the test provides aUserpk. This PR fixes that and provides the correct pk.AllocationChangeViewTestAllocationChangeViewTestset the url to"/allocation/1/change-request". This PR changes it tof"/allocation/{self.allocation.pk}/change-request", fixing a 404 reply.ProjectListViewTest.test_project_list_searchassertIninstead ofassertEquals(len(...)), fixing the intermittent failures.coldfront.core.allocation.tests.test_modelstimezone.now()calls in test_models.py withdatetime.date.now(), since that's what the model uses.