Skip to content

Update MOM6 with inline-CDEPS capability#3033

Closed
DeniseWorthen wants to merge 109 commits intoufs-community:developfrom
DeniseWorthen:feature/mom6cdeps
Closed

Update MOM6 with inline-CDEPS capability#3033
DeniseWorthen wants to merge 109 commits intoufs-community:developfrom
DeniseWorthen:feature/mom6cdeps

Conversation

@DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Dec 23, 2025

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

Updates MOM6 to include CDEPS inline capability.

Commit Message:

 * MOM6 - enable CDEPS inline 

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:


Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DeniseWorthen
Copy link
Collaborator Author

DeniseWorthen commented Jan 6, 2026

@FernandoAndrade-NOAA Don't worry. I was able to compare a single test. I don't have any ideas right now about what is going on, other than I think it has to be in the build to compile the parts of CDEPS I need inside of MOM6.

The debug case is working fine.

@DeniseWorthen
Copy link
Collaborator Author

@FernandoAndrade-NOAA I would prefer you move on today to the next available PR. I don't know how long it will take me to figure out why this is failing on Gaea.

@DeniseWorthen
Copy link
Collaborator Author

DeniseWorthen commented Jan 7, 2026

@FernandoAndrade-NOAA I'm also not able to even log onto C6 today. I know C5 is having facility work, but we were told that C6 would be unaffected. Are you able to log into C6?

EDIT: I've been able to log into gaea63 now.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA I would prefer you move on today to the next available PR. I don't know how long it will take me to figure out why this is failing on Gaea.

Understood, we'll move onto the next PR thank you.

@FernandoAndrade-NOAA FernandoAndrade-NOAA removed In Testing The PR that is currently in testing stages Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Jan 7, 2026
@FernandoAndrade-NOAA FernandoAndrade-NOAA moved this from Schedule to Not Ready in PRs to Process Jan 7, 2026
@DeniseWorthen
Copy link
Collaborator Author

DeniseWorthen commented Jan 7, 2026

@FernandoAndrade-NOAA I've made a fix and tested on C6 for a subset (26) of the failing tests, all of which now pass. I had to modify the Cmake build because on C6, there are special flags applied to MOM6 compilation

set(MOM6_Extra_FORTRAN_FLAGS "-xsse2")

And that flag was getting used to build CDEPS. I think I've done things "the right way" now, but other platforms will need to be verified again.

I am seeing excessively long compile times for some jobs on C6. Have you noticed that?

@JessicaMeixner-NOAA
Copy link
Collaborator

I've seen weird filesystem / slow runtimes in general today on c6.

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA I've made a fix and tested on C6 for a subset (26) of the failing tests, all of which now pass. I had to modify the Cmake build because on C6, there are special flags applied to MOM6 compilation

set(MOM6_Extra_FORTRAN_FLAGS "-xsse2")

And that flag was getting used to build CDEPS. I think I've done things "the right way" now, but other platforms will need to be verified again.

I am seeing excessively long compile times for some jobs on C6. Have you noticed that?

I've seen weird filesystem / slow runtimes in general today on c6.

I'm wondering if the extended C5 maintenance is somehow affecting this, I'll be sure to compare compile times with the current PR against develop when those finish on C6.

@DeniseWorthen DeniseWorthen changed the title Update MOM6 with inline-CDEPS capability; Fix UFSATM CI github action (was #3035) Update MOM6 with inline-CDEPS capability Jan 7, 2026
@FernandoAndrade-NOAA
Copy link
Collaborator

Just leaving a note here that I do see some relatively significant variation in some of the compile times on C6 with the current PR as well.

@gspetro-NOAA gspetro-NOAA moved this from Not Ready to Review in PRs to Process Jan 9, 2026
@DeniseWorthen
Copy link
Collaborator Author

DeniseWorthen commented Jan 9, 2026

@FernandoAndrade-NOAA @gspetro-NOAA I ran the full RT on C6. A few compiles were longer, most were w/in normal variablilty. I don't see any pattern which can be attributed to this PR.

@gspetro-NOAA gspetro-NOAA added the On Deck This is the next PR in line for testing/merge. label Jan 12, 2026
@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Jan 12, 2026
gspetro-NOAA pushed a commit that referenced this pull request Jan 13, 2026
…with inline-CDEPS capability #3033 (#3044)

* UFSWM - Change MOM6_OUTPUT_FH name to add consistency 
  * MOM6 - enable CDEPS inline
@gspetro-NOAA
Copy link
Collaborator

Merged via #3044

@github-project-automation github-project-automation bot moved this from Schedule to Done in PRs to Process Jan 13, 2026
@gspetro-NOAA gspetro-NOAA removed the On Deck This is the next PR in line for testing/merge. label Jan 13, 2026
@DeniseWorthen DeniseWorthen deleted the feature/mom6cdeps branch February 19, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MOM There are changes to the MOM6 component repository. No Baseline Change No Baseline Change

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add CDEPS inline capability to MOM6 NUOPC cap

8 participants