Suppress new cppcheck 2.18 diagnostics as the fix performance impact is unknown

[laurynas-biveinis]

cppcheck 2.18 suggests to use std::find_if, which is a reasonable suggestion,
but I have not verified the compiled code yet.

Summary by CodeRabbit

• Chores
  • Internal code maintenance and quality improvements with no impact on user-facing features or functionality.

[coderabbitai]

Walkthrough

cppcheck suppression comments are inserted into iterator begin/next implementations for N48 and N256 inode types in art_internal_impl.hpp, preceding conditional checks that iterate over internal arrays. No functional changes.

Changes

Cohort / File(s)	Summary
cppcheck suppression comments art_internal_impl.hpp	Added // cppcheck-suppress useStlAlgorithm directives before loop conditionals in N48 and N256 iterator begin/next methods to suppress static analysis warnings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Mechanically straightforward suppression comment additions with no logic changes or side effects.

Poem

🔇 Suppression comments whisper soft,
Silencing cppcheck's warning aloft,
The code flows on, untouched and true,
Static analysis quiet, analysis through. ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Suppress new cppcheck 2.18 diagnostics as the fix performance impact is unknown" directly and accurately reflects the changeset. The raw summary confirms that the PR adds cppcheck suppression comments to address new diagnostics from cppcheck 2.18. The title is specific (mentions the tool version and reason for suppression), concise (12 words), and leaves no ambiguity about what the change accomplishes. It clearly summarizes the primary action without vague language or noise.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cppcheck-2.18

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f268f26 and 0d0dd0d.

📒 Files selected for processing (1)

• art_internal_impl.hpp (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (2)

art_internal_impl.hpp (2)

2721-2732: This review comment is unsupported and unactionable.

The suggestion asks to add a TODO/issue reference but provides no specific reference, issue number, or tracking ID. The claim about "pending performance verification" has no backing evidence in the codebase—no performance TODOs exist, and the same bare suppressions appear consistently across all iterator implementations (N48 and I256). The suppression pattern appears intentional, not incomplete. The developer cannot act on a vague instruction to "add tracking context" without knowing what to add.

Likely an incorrect or invalid review comment.

---

2401-2411: This review comment is incorrect.

The suppression at line 2402 already includes inline documentation explaining the rationale ("loop over the remaining byte values in lexical order"). More critically, your claim about "pending performance verification" doesn't exist anywhere in the codebase—this is either a mischaracterization or confusion with a different issue.

Additionally, your concern applies equally to all four cppcheck-suppress useStlAlgorithm occurrences in this file (lines 2366, 2402, 2722, 2755), yet you've selectively criticized only two. Either the standard applies universally or it doesn't.

The existing inline comments already provide context for why manual iteration is used here. Adding TODO references would be fine as a stylistic improvement across the entire file, but that's not what this code needs to be correct.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud