Skip to content

Suppress new cppcheck 2.18 diagnostics as the fix performance impact is unknown #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurynas-biveinis merged 1 commit into from
Nov 3, 2025
Merged

Suppress new cppcheck 2.18 diagnostics as the fix performance impact is unknown #796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions art_internal_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2363,6 +2363,7 @@ class basic_inode_48 : public basic_inode_48_parent<ArtPolicy> {
[[nodiscard, gnu::pure]] constexpr typename basic_inode_48::iter_result
begin() noexcept {
for (std::uint64_t i = 0; i < 256; i++) {
// cppcheck-suppress useStlAlgorithm
if (child_indexes[i] != empty_child) {
const auto key = static_cast<std::byte>(i);
const auto child_index = static_cast<std::uint8_t>(i);
Expand Down Expand Up @@ -2398,6 +2399,7 @@ class basic_inode_48 : public basic_inode_48_parent<ArtPolicy> {
next(std::uint8_t child_index) noexcept {
// loop over the remaining byte values in lexical order.
for (auto i = static_cast<std::uint64_t>(child_index) + 1; i < 256; i++) {
// cppcheck-suppress useStlAlgorithm
if (child_indexes[i] != empty_child) {
const auto key = static_cast<std::byte>(i);
const auto next_index = static_cast<std::uint8_t>(i);
Expand Down Expand Up @@ -2717,6 +2719,7 @@ class basic_inode_256 : public basic_inode_256_parent<ArtPolicy> {
[[nodiscard, gnu::pure]] constexpr typename basic_inode_256::iter_result
begin() noexcept {
for (std::uint64_t i = 0; i < basic_inode_256::capacity; i++) {
// cppcheck-suppress useStlAlgorithm
if (children[i] != nullptr) {
const auto key = static_cast<std::byte>(i); // child_index is key byte
const auto child_index = static_cast<std::uint8_t>(i);
Expand Down Expand Up @@ -2749,6 +2752,7 @@ class basic_inode_256 : public basic_inode_256_parent<ArtPolicy> {
// loop over the remaining byte values in lexical order.
for (auto i = static_cast<std::uint64_t>(child_index) + 1;
i < basic_inode_256::capacity; i++) {
// cppcheck-suppress useStlAlgorithm
if (children[i] != nullptr) {
const auto key = static_cast<std::byte>(i);
const auto next_index = static_cast<std::uint8_t>(i);
Expand Down
Loading