Skip to content

Conversation

sarthakaggarwal97
Copy link
Contributor

Resolves #4

Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.21%. Comparing base (d21d529) to head (158b61b).
⚠️ Report is 2 commits behind head on unstable.

Files with missing lines Patch % Lines
src/config.c 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2608      +/-   ##
============================================
+ Coverage     72.19%   72.21%   +0.02%     
============================================
  Files           127      127              
  Lines         70935    70953      +18     
============================================
+ Hits          51209    51238      +29     
+ Misses        19726    19715      -11     
Files with missing lines Coverage Δ
src/server.c 88.43% <100.00%> (+0.04%) ⬆️
src/server.h 100.00% <ø> (ø)
src/util.c 66.53% <100.00%> (+0.31%) ⬆️
src/config.c 78.50% <42.85%> (-0.16%) ⬇️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review September 23, 2025 17:22
@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as draft September 23, 2025 17:45
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the fix-scan-consistency branch 3 times, most recently from b8ad08a to f0bccf7 Compare September 23, 2025 18:50
@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review September 23, 2025 18:50
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the fix-scan-consistency branch 3 times, most recently from 491c7bd to a0dcf78 Compare September 24, 2025 21:24
@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as draft September 24, 2025 21:24
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the fix-scan-consistency branch 3 times, most recently from 31356e8 to a678a68 Compare September 24, 2025 23:14
Signed-off-by: Sarthak Aggarwal <[email protected]>
@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review September 25, 2025 00:57
@sarthakaggarwal97
Copy link
Contributor Author

@madolson I think it's ready for review 🙂

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
@sarthakaggarwal97
Copy link
Contributor Author

@madolson thanks for the review, I think I have addressed all the comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCAN, SSCAN, HSCAN, and ZSCAN are not stable across failovers
2 participants