Repository navigation
fix(ci): fix vdev release race between matrix jobs - #26631
Merged
Merged
Conversation
thomasqueirozb
marked this pull request as ready for review
October 9, 2026 19:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
thomasqueirozb
enabled auto-merge
October 9, 2026 19:18
pront
approved these changes
Oct 9, 2026
There was a problem hiding this comment.
More details
Release creation and publication now happen in one job after all three architecture builds stage their assets, removing the concurrent operations responsible for duplicate notifications and orphan drafts.
🤖 Bits Code Review · Commit d86e75e
Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some vdev releases produce two Slack release notifications and leave an empty draft release behind.
Root cause: each of the 3
buildmatrix jobs invdev_publish.ymlransoftprops/action-gh-releaseon the same tag, and the jobs raced:draft: false) after its upload. A job that fetched the release while it was still a draft sends its own publish call, and GitHub emitspublishedagain. Forvdev-v0.3.29(release408184724), the repo event feed has twopublishedevents: 17:49:47 (arm job) and 17:49:49 (x86 job). The GitHub Slack app posts once per event.vdev-v0.3.28, the x86 and arm jobs created a draft at the same time. The x86 job loggedUsing release 407162844 ... instead of duplicate draft 407162873but did not delete its draft. The release listing did not show the new draft yet, so the action skipped its cleanup. Draft407162873(0 assets) is still there.It is intermittent because it depends on build timing. When a job sees an already-published release, it does nothing.
The fix follows the
publish.ymlpattern. Build jobs stage their tarballs as artifacts, and onereleasejob creates and publishes the release with all assets.References
NA
Vector configuration
NA
How did you test this PR?
make check-actionlintvectordotdev/ci-sandbox(run). The cargo build andcargo publishsteps were stubbed. Result: one non-draft release with all 3 assets, exactly onepublishedevent, and no drafts.Does this PR include user facing changes?
no-changeloglabel to this PR.