Skip to content

fix(ci): fix vdev release race between matrix jobs - #26631

Merged
thomasqueirozb merged 2 commits into
masterfrom
fix/vdev-release-race
Oct 9, 2026
Merged

thomasqueirozb merged 2 commits into
masterfrom
fix/vdev-release-race

Conversation

@thomasqueirozb

@thomasqueirozb thomasqueirozb commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary

Some vdev releases produce two Slack release notifications and leave an empty draft release behind.

Root cause: each of the 3 build matrix jobs in vdev_publish.yml ran softprops/action-gh-release on the same tag, and the jobs raced:

  • Duplicate notifications: each job publishes the release (draft: false) after its upload. A job that fetched the release while it was still a draft sends its own publish call, and GitHub emits published again. For vdev-v0.3.29 (release 408184724), the repo event feed has two published events: 17:49:47 (arm job) and 17:49:49 (x86 job). The GitHub Slack app posts once per event.
  • Orphan drafts: for vdev-v0.3.28, the x86 and arm jobs created a draft at the same time. The x86 job logged Using release 407162844 ... instead of duplicate draft 407162873 but did not delete its draft. The release listing did not show the new draft yet, so the action skipped its cleanup. Draft 407162873 (0 assets) is still there.

It is intermittent because it depends on build timing. When a job sees an already-published release, it does nothing.

The fix follows the publish.yml pattern. Build jobs stage their tarballs as artifacts, and one release job creates and publishes the release with all assets.

References

NA

Vector configuration

NA

How did you test this PR?

  • make check-actionlint
  • Ran the workflow in vectordotdev/ci-sandbox (run). The cargo build and cargo publish steps were stubbed. Result: one non-draft release with all 3 assets, exactly one published event, and no drafts.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 9, 2026
@github-actions github-actions Bot added the domain: ci Anything related to Vector's CI environment label Oct 9, 2026
@thomasqueirozb
thomasqueirozb marked this pull request as ready for review October 9, 2026 19:17
@thomasqueirozb
thomasqueirozb requested a review from a team as a code owner October 9, 2026 19:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T19:19:05.073778Z d86e75e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread .github/workflows/vdev_publish.yml Outdated

@datadoghq-integration datadoghq-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Release creation and publication now happen in one job after all three architecture builds stage their assets, removing the concurrent operations responsible for duplicate notifications and orphan drafts.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit d86e75e

Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>
@thomasqueirozb
thomasqueirozb added this pull request to the merge queue Oct 9, 2026
Merged via the queue into master with commit f6cf6c9 Oct 9, 2026
62 checks passed
@thomasqueirozb
thomasqueirozb deleted the fix/vdev-release-race branch October 9, 2026 19:47
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants