Skip to content

fix(ci): fix vdev release race between matrix jobs #26631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasqueirozb merged 2 commits into from
Oct 9, 2026
Merged

fix(ci): fix vdev release race between matrix jobs #26631

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d86e75e
fix(ci): fix vdev release race between matrix jobs
thomasqueirozb Oct 9, 2026
dbf0c0e
Apply suggestion from @pront
thomasqueirozb Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions .github/workflows/vdev_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ permissions:
jobs:
build:
runs-on: ${{ matrix.os }}
permissions:
contents: write # Required to upload release assets
strategy:
matrix:
include:
Expand Down Expand Up @@ -53,16 +51,40 @@ jobs:
tar -czf "${OUTDIR}.tgz" "$OUTDIR"
echo "ASSET=${OUTDIR}.tgz" >> "$GITHUB_ENV"

- name: Upload asset to release
- name: Stage asset for release
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: vdev-${{ matrix.target }}
path: ${{ env.ASSET }}
if-no-files-found: error

# Create and publish the release from one job. When each matrix job ran the
# release action, they raced: each could create its own draft (leaving orphans)
# and each finalized the release, so GitHub emitted `published` more than once.
Comment thread
thomasqueirozb marked this conversation as resolved.
Outdated
release:
runs-on: ubuntu-24.04
needs: build
permissions:
contents: write # Required to create the release and upload assets
steps:
- name: Download staged assets
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
pattern: vdev-*
path: assets
merge-multiple: true

- name: Publish GitHub release
uses: softprops/action-gh-release@efb35369e0ad2afab669f228072c1b0d510eae64 # v3.0.3
with:
files: ${{ env.ASSET }}
files: assets/*.tgz
fail_on_unmatched_files: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

publish:
runs-on: ubuntu-24.04
needs: build
needs: release
env:
DISABLE_MOLD: true
steps:
Expand Down
Loading