docs(turbopack): Migrate docs about traits from mdbook to rustdocs by bgw · Pull Request #91170 · vercel/next.js

bgw · 2026-03-10T21:43:45Z

Migrates the content from https://turbopack-rust-docs.vercel.sh/turbo-engine/traits.html over to rustdocs, and tries to update/fix some minor mistakes our outdated docs.

vercel · 2026-03-10T21:43:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
v0-next-js	Error	Open in v0	Mar 10, 2026 9:45pm

bgw · 2026-03-10T21:44:00Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

turbopack/crates/turbo-tasks/src/lib.rs

turbopack/crates/turbo-tasks/src/vc/traits.rs

nextjs-bot · 2026-03-10T22:01:12Z

Tests Passed

codspeed-hq · 2026-03-10T22:09:47Z

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing bgw/turbo-tasks-traits-docs (5772998) with bgw/turbo-tasks-task-input-docs (dfc69dd)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on bgw/turbo-tasks-task-input-docs (72bc972) during the generation of this report, so a844590 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

turbopack/crates/turbo-tasks/src/lib.rs

turbopack/crates/turbo-tasks/src/vc/traits.rs

nextjs-bot · 2026-03-11T02:21:23Z

Stats from current PR

✅ No significant changes detected

📊 All Metrics

📖 Metrics Glossary

Dev Server Metrics:

Listen = TCP port starts accepting connections
First Request = HTTP server returns successful response
Cold = Fresh build (no cache)
Warm = With cached build artifacts

Build Metrics:

Fresh = Clean build (no .next directory)
Cached = With existing .next directory

Change Thresholds:

Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
Size: Changes < 1KB AND < 1% are insignificant
All other changes are flagged to catch regressions

⚡ Dev Server

Metric	Canary	PR	Change	Trend
Cold (Listen)	455ms	456ms	✓	▁██▁▁
Cold (Ready in log)	439ms	439ms	✓	▁██▁▁
Cold (First Request)	1.194s	1.261s	✓	▁██▃▁
Warm (Listen)	457ms	457ms	✓	▁██▁▁
Warm (Ready in log)	443ms	446ms	✓	▁██▁▁
Warm (First Request)	348ms	350ms	✓	▁██▁▁

📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric	Canary	PR	Change	Trend
Cold (Listen)	457ms	455ms	✓	▁▅▁▁▁
Cold (Ready in log)	438ms	438ms	✓	▁▄▃▃▃
Cold (First Request)	1.927s	1.926s	✓	▁▅▂▂▂
Warm (Listen)	456ms	457ms	✓	▁▄▁▁▁
Warm (Ready in log)	438ms	438ms	✓	▁▆▄▄▃
Warm (First Request)	1.944s	1.938s	✓	▁▆▂▂▂

⚡ Production Builds

Metric	Canary	PR	Change	Trend
Fresh Build	3.893s	3.833s	✓	▁█▇▁▁
Cached Build	3.867s	3.888s	✓	▁██▁▁

📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric	Canary	PR	Change	Trend
Fresh Build	14.014s	14.115s	✓	▁▅▁▁▁
Cached Build	14.141s	14.195s	✓	▁▅▁▁▁
node_modules Size	477 MB	477 MB	✓	▁▁▁▁▁

📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **402 kB** → **402 kB** ✅ -25 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	770 B	764 B	✓
Total	770 B	764 B	✅ -6 B

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	450 B	451 B	✓
Total	450 B	451 B	⚠️ +1 B

📦 Webpack

Client

Main Bundles

	Canary	PR	Change
5528-HASH.js gzip	5.54 kB	N/A	-
6280-HASH.js gzip	59.6 kB	N/A	-
6335.HASH.js gzip	169 B	N/A	-
912-HASH.js gzip	4.59 kB	N/A	-
e8aec2e4-HASH.js gzip	62.6 kB	N/A	-
framework-HASH.js gzip	59.7 kB	59.7 kB	✓
main-app-HASH.js gzip	255 B	254 B	✓
main-HASH.js gzip	39.2 kB	39.2 kB	✓
webpack-HASH.js gzip	1.68 kB	1.68 kB	✓
262-HASH.js gzip	N/A	4.59 kB	-
2889.HASH.js gzip	N/A	169 B	-
5602-HASH.js gzip	N/A	5.55 kB	-
6948ada0-HASH.js gzip	N/A	62.6 kB	-
9544-HASH.js gzip	N/A	60.3 kB	-
Total	233 kB	234 kB	⚠️ +733 B

Polyfills

	Canary	PR	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Total	39.4 kB	39.4 kB	✓

Pages

	Canary	PR	Change
_app-HASH.js gzip	194 B	194 B	✓
_error-HASH.js gzip	183 B	180 B	🟢 3 B (-2%)
css-HASH.js gzip	331 B	330 B	✓
dynamic-HASH.js gzip	1.81 kB	1.81 kB	✓
edge-ssr-HASH.js gzip	256 B	256 B	✓
head-HASH.js gzip	351 B	352 B	✓
hooks-HASH.js gzip	384 B	383 B	✓
image-HASH.js gzip	580 B	581 B	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	2.51 kB	2.51 kB	✓
routerDirect..HASH.js gzip	320 B	319 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	315 B	315 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Total	7.98 kB	7.98 kB	✅ -1 B

Server

Edge SSR

	Canary	PR	Change
edge-ssr.js gzip	125 kB	125 kB	✓
page.js gzip	257 kB	257 kB	✓
Total	381 kB	382 kB	⚠️ +526 B

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	617 B	616 B	✓
middleware-r..fest.js gzip	156 B	155 B	✓
middleware.js gzip	43.8 kB	43.9 kB	✓
edge-runtime..pack.js gzip	842 B	842 B	✓
Total	45.4 kB	45.5 kB	⚠️ +99 B

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	715 B	718 B	✓
Total	715 B	718 B	⚠️ +3 B

Build Cache

	Canary	PR	Change
0.pack gzip	4.08 MB	4.08 MB	🔴 +4.51 kB (+0%)
index.pack gzip	104 kB	102 kB	🟢 1.63 kB (-2%)
index.pack.old gzip	103 kB	103 kB	✓
Total	4.28 MB	4.29 MB	⚠️ +3.4 kB

🔄 Shared (bundler-independent)

Runtimes

	Canary	PR	Change
app-page-exp...dev.js gzip	323 kB	323 kB	✓
app-page-exp..prod.js gzip	171 kB	171 kB	✓
app-page-tur...dev.js gzip	322 kB	322 kB	✓
app-page-tur..prod.js gzip	171 kB	171 kB	✓
app-page-tur...dev.js gzip	319 kB	319 kB	✓
app-page-tur..prod.js gzip	169 kB	169 kB	✓
app-page.run...dev.js gzip	319 kB	319 kB	✓
app-page.run..prod.js gzip	170 kB	170 kB	✓
app-route-ex...dev.js gzip	70.9 kB	70.9 kB	✓
app-route-ex..prod.js gzip	49.3 kB	49.3 kB	✓
app-route-tu...dev.js gzip	70.9 kB	70.9 kB	✓
app-route-tu..prod.js gzip	49.3 kB	49.3 kB	✓
app-route-tu...dev.js gzip	70.5 kB	70.5 kB	✓
app-route-tu..prod.js gzip	49.1 kB	49.1 kB	✓
app-route.ru...dev.js gzip	70.5 kB	70.5 kB	✓
app-route.ru..prod.js gzip	49 kB	49 kB	✓
dist_client_...dev.js gzip	324 B	324 B	✓
dist_client_...dev.js gzip	326 B	326 B	✓
dist_client_...dev.js gzip	318 B	318 B	✓
dist_client_...dev.js gzip	317 B	317 B	✓
pages-api-tu...dev.js gzip	43.3 kB	43.3 kB	✓
pages-api-tu..prod.js gzip	32.9 kB	32.9 kB	✓
pages-api.ru...dev.js gzip	43.2 kB	43.2 kB	✓
pages-api.ru..prod.js gzip	32.9 kB	32.9 kB	✓
pages-turbo....dev.js gzip	52.6 kB	52.6 kB	✓
pages-turbo...prod.js gzip	38.5 kB	38.5 kB	✓
pages.runtim...dev.js gzip	52.6 kB	52.6 kB	✓
pages.runtim..prod.js gzip	38.5 kB	38.5 kB	✓
server.runti..prod.js gzip	62 kB	62 kB	✓
Total	2.84 MB	2.84 MB	✓

📎 Tarball URL

https://vercel-packages.vercel.app/next/commits/57729989c8dc401bce670b59edfe156cec61a9c1/next

nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 10, 2026

This was referenced Mar 10, 2026

docs(contributing): Update setup in contributing/core/developing.md #91018

Merged

docs(turbopack): Merge task input docs from mdbook into rustdocs #91136

Open

vercel bot had a problem deploying to Preview March 10, 2026 21:45 Failure

vercel bot reviewed Mar 10, 2026

View reviewed changes

turbopack/crates/turbo-tasks/src/lib.rs Outdated Show resolved Hide resolved

turbopack/crates/turbo-tasks/src/vc/traits.rs Outdated Show resolved Hide resolved

bgw marked this pull request as ready for review March 10, 2026 21:53

bgw force-pushed the bgw/turbo-tasks-traits-docs branch from e5d2176 to dd1164f Compare March 10, 2026 22:18

bgw force-pushed the bgw/turbo-tasks-task-input-docs branch from e092b40 to d38fe93 Compare March 10, 2026 22:18

bgw requested review from a team, icyJoseph and mmastrac March 10, 2026 22:18

bgw mentioned this pull request Mar 11, 2026

docs(turbopack): Move singleton pattern documentation from mdbook to rustdoc #91175

Open

lukesandberg reviewed Mar 11, 2026

View reviewed changes

turbopack/crates/turbo-tasks/src/lib.rs Outdated Show resolved Hide resolved

lukesandberg reviewed Mar 11, 2026

View reviewed changes

turbopack/crates/turbo-tasks/src/vc/traits.rs Outdated Show resolved Hide resolved

lukesandberg reviewed Mar 11, 2026

View reviewed changes

turbopack/crates/turbo-tasks/src/vc/traits.rs Outdated Show resolved Hide resolved

lukesandberg reviewed Mar 11, 2026

View reviewed changes

turbopack/crates/turbo-tasks/src/vc/traits.rs Outdated Show resolved Hide resolved

lukesandberg approved these changes Mar 11, 2026

View reviewed changes

bgw force-pushed the bgw/turbo-tasks-task-input-docs branch from d38fe93 to 58772b2 Compare March 11, 2026 01:57

bgw force-pushed the bgw/turbo-tasks-traits-docs branch from dd1164f to 17530b3 Compare March 11, 2026 01:57

bgw force-pushed the bgw/turbo-tasks-task-input-docs branch from 58772b2 to dfc69dd Compare March 11, 2026 21:51

bgw force-pushed the bgw/turbo-tasks-traits-docs branch from 17530b3 to c2ed84c Compare March 11, 2026 21:51

bgw mentioned this pull request Mar 11, 2026

Turbopack: Remove the IntoTraitRef trait, make it an inherent method on Vc #91223

Open

bgw force-pushed the bgw/turbo-tasks-task-input-docs branch from dfc69dd to 72bc972 Compare March 11, 2026 22:23

bgw added 2 commits March 11, 2026 22:24

docs(turbopack): Migrate docs about traits from mdbook to rustdocs

08fad6e

Address comments, typos

5772998

bgw force-pushed the bgw/turbo-tasks-traits-docs branch from c2ed84c to 5772998 Compare March 11, 2026 22:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(turbopack): Migrate docs about traits from mdbook to rustdocs#91170

docs(turbopack): Migrate docs about traits from mdbook to rustdocs#91170
bgw wants to merge 2 commits intobgw/turbo-tasks-task-input-docsfrom
bgw/turbo-tasks-traits-docs

bgw commented Mar 10, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

bgw commented Mar 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

nextjs-bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nextjs-bot commented Mar 11, 2026 •

edited

Loading

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bgw commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bgw commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nextjs-bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests Passed

Uh oh!

codspeed-hq bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nextjs-bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stats from current PR

✅ No significant changes detected

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bgw commented Mar 10, 2026 •

edited

Loading

vercel bot commented Mar 10, 2026 •

edited

Loading

bgw commented Mar 10, 2026 •

edited

Loading

nextjs-bot commented Mar 10, 2026 •

edited

Loading

codspeed-hq bot commented Mar 10, 2026 •

edited

Loading

nextjs-bot commented Mar 11, 2026 •

edited

Loading