Turbopack: Remove the IntoTraitRef trait, make it an inherent method on Vc by bgw · Pull Request #91223 · vercel/next.js

bgw · 2026-03-11T22:19:03Z

This is basically one-shot from Opus 4.6, with a minor tweak to the doc comment by hand.

Discussed this with @lukesandberg, and we realized that there's only one implementation of this trait, so it doesn't make a ton of sense as a trait.

bgw · 2026-03-11T22:19:26Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-03-11T22:26:16Z

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing bgw/into-trait-ref-inherent-method (e8f37f2) with bgw/turbo-tasks-singleton-docs (7ad9a2a)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on bgw/turbo-tasks-singleton-docs (dedb6b8) during the generation of this report, so b4fc9d8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

nextjs-bot · 2026-03-11T22:44:54Z

Stats from current PR

✅ No significant changes detected

📊 All Metrics

📖 Metrics Glossary

Dev Server Metrics:

Listen = TCP port starts accepting connections
First Request = HTTP server returns successful response
Cold = Fresh build (no cache)
Warm = With cached build artifacts

Build Metrics:

Fresh = Clean build (no .next directory)
Cached = With existing .next directory

Change Thresholds:

Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
Size: Changes < 1KB AND < 1% are insignificant
All other changes are flagged to catch regressions

⚡ Dev Server

Metric	Canary	PR	Change	Trend
Cold (Listen)	559ms	559ms	✓	▁██▁▁
Cold (Ready in log)	553ms	563ms	✓	▁██▁▁
Cold (First Request)	1.232s	1.244s	✓	▁██▃▁
Warm (Listen)	559ms	560ms	✓	▁██▁▁
Warm (Ready in log)	549ms	555ms	✓	▁██▁▁
Warm (First Request)	444ms	446ms	✓	▁██▁▁

📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric	Canary	PR	Change	Trend
Cold (Listen)	456ms	457ms	✓	▁▅▁▁▁
Cold (Ready in log)	441ms	442ms	✓	▁▄▃▃▃
Cold (First Request)	1.869s	1.862s	✓	▁▅▂▂▂
Warm (Listen)	456ms	457ms	✓	▁▄▁▁▁
Warm (Ready in log)	439ms	442ms	✓	▁▆▄▄▃
Warm (First Request)	1.861s	1.860s	✓	▁▆▂▂▂

⚡ Production Builds

Metric	Canary	PR	Change	Trend
Fresh Build	5.124s	5.289s	✓	▁█▇▁▁
Cached Build	5.201s	5.170s	✓	▁██▁▁

📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric	Canary	PR	Change	Trend
Fresh Build	13.985s	14.009s	✓	▁▅▁▁▁
Cached Build	14.025s	14.021s	✓	▁▅▁▁▁
node_modules Size	477 MB	477 MB	✓	▁▁▁▁▁

📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **402 kB** → **402 kB** ✅ -25 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	770 B	764 B	✓
Total	770 B	764 B	✅ -6 B

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	450 B	451 B	✓
Total	450 B	451 B	⚠️ +1 B

📦 Webpack

Client

Main Bundles

	Canary	PR	Change
5528-HASH.js gzip	5.54 kB	N/A	-
6280-HASH.js gzip	59.6 kB	N/A	-
6335.HASH.js gzip	169 B	N/A	-
912-HASH.js gzip	4.59 kB	N/A	-
e8aec2e4-HASH.js gzip	62.6 kB	N/A	-
framework-HASH.js gzip	59.7 kB	59.7 kB	✓
main-app-HASH.js gzip	256 B	254 B	✓
main-HASH.js gzip	39.2 kB	39.2 kB	✓
webpack-HASH.js gzip	1.68 kB	1.68 kB	✓
262-HASH.js gzip	N/A	4.59 kB	-
2889.HASH.js gzip	N/A	169 B	-
5602-HASH.js gzip	N/A	5.55 kB	-
6948ada0-HASH.js gzip	N/A	62.6 kB	-
9544-HASH.js gzip	N/A	60.3 kB	-
Total	233 kB	234 kB	⚠️ +732 B

Polyfills

	Canary	PR	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Total	39.4 kB	39.4 kB	✓

Pages

	Canary	PR	Change
_app-HASH.js gzip	194 B	194 B	✓
_error-HASH.js gzip	183 B	180 B	🟢 3 B (-2%)
css-HASH.js gzip	331 B	330 B	✓
dynamic-HASH.js gzip	1.81 kB	1.81 kB	✓
edge-ssr-HASH.js gzip	256 B	256 B	✓
head-HASH.js gzip	351 B	352 B	✓
hooks-HASH.js gzip	384 B	383 B	✓
image-HASH.js gzip	580 B	581 B	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	2.51 kB	2.51 kB	✓
routerDirect..HASH.js gzip	320 B	319 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	315 B	315 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Total	7.98 kB	7.98 kB	✅ -1 B

Server

Edge SSR

	Canary	PR	Change
edge-ssr.js gzip	125 kB	125 kB	✓
page.js gzip	257 kB	257 kB	✓
Total	381 kB	382 kB	⚠️ +477 B

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	618 B	618 B	✓
middleware-r..fest.js gzip	156 B	155 B	✓
middleware.js gzip	43.9 kB	43.9 kB	✓
edge-runtime..pack.js gzip	842 B	842 B	✓
Total	45.5 kB	45.5 kB	✅ -45 B

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	715 B	718 B	✓
Total	715 B	718 B	⚠️ +3 B

Build Cache

	Canary	PR	Change
0.pack gzip	4.08 MB	4.08 MB	🔴 +5.23 kB (+0%)
index.pack gzip	103 kB	102 kB	🟢 1.22 kB (-1%)
index.pack.old gzip	103 kB	103 kB	✓
Total	4.29 MB	4.29 MB	⚠️ +4.15 kB

🔄 Shared (bundler-independent)

Runtimes

	Canary	PR	Change
app-page-exp...dev.js gzip	323 kB	323 kB	✓
app-page-exp..prod.js gzip	171 kB	171 kB	✓
app-page-tur...dev.js gzip	322 kB	322 kB	✓
app-page-tur..prod.js gzip	171 kB	171 kB	✓
app-page-tur...dev.js gzip	319 kB	319 kB	✓
app-page-tur..prod.js gzip	169 kB	169 kB	✓
app-page.run...dev.js gzip	319 kB	319 kB	✓
app-page.run..prod.js gzip	170 kB	170 kB	✓
app-route-ex...dev.js gzip	70.9 kB	70.9 kB	✓
app-route-ex..prod.js gzip	49.3 kB	49.3 kB	✓
app-route-tu...dev.js gzip	70.9 kB	70.9 kB	✓
app-route-tu..prod.js gzip	49.3 kB	49.3 kB	✓
app-route-tu...dev.js gzip	70.5 kB	70.5 kB	✓
app-route-tu..prod.js gzip	49.1 kB	49.1 kB	✓
app-route.ru...dev.js gzip	70.5 kB	70.5 kB	✓
app-route.ru..prod.js gzip	49 kB	49 kB	✓
dist_client_...dev.js gzip	324 B	324 B	✓
dist_client_...dev.js gzip	326 B	326 B	✓
dist_client_...dev.js gzip	318 B	318 B	✓
dist_client_...dev.js gzip	317 B	317 B	✓
pages-api-tu...dev.js gzip	43.3 kB	43.3 kB	✓
pages-api-tu..prod.js gzip	32.9 kB	32.9 kB	✓
pages-api.ru...dev.js gzip	43.2 kB	43.2 kB	✓
pages-api.ru..prod.js gzip	32.9 kB	32.9 kB	✓
pages-turbo....dev.js gzip	52.6 kB	52.6 kB	✓
pages-turbo...prod.js gzip	38.5 kB	38.5 kB	✓
pages.runtim...dev.js gzip	52.6 kB	52.6 kB	✓
pages.runtim..prod.js gzip	38.5 kB	38.5 kB	✓
server.runti..prod.js gzip	62 kB	62 kB	✓
Total	2.84 MB	2.84 MB	✅ -2 B

📎 Tarball URL

https://vercel-packages.vercel.app/next/commits/de250e35a651fdde67b4047e24deeb02ba39f8e3/next

nextjs-bot · 2026-03-11T22:45:17Z

Failing test suites

Commit: e8f37f2 | About building and testing Next.js

pnpm test-start test/production/app-dir/server-action-period-hash/server-action-period-hash.test.ts (job)

app-dir - server-action-period-hash > should have same manifest between continuous two builds (DD)
app-dir - server-action-period-hash > should have different manifest between two builds with period hash (DD)

Expand output

● app-dir - server-action-period-hash › should have same manifest between continuous two builds

can not run export while server is running, use next.stop() first

  251 |   ) {
  252 |     if (this.childProcess) {
> 253 |       throw new Error(
      |             ^
  254 |         `can not run export while server is running, use next.stop() first`
  255 |       )
  256 |     }

  at NextStartInstance.build (lib/next-modes/next-start.ts:253:13)
  at Object.build (production/app-dir/server-action-period-hash/server-action-period-hash.test.ts:17:16)

● app-dir - server-action-period-hash › should have different manifest between two builds with period hash

can not run export while server is running, use next.stop() first

  251 |   ) {
  252 |     if (this.childProcess) {
> 253 |       throw new Error(
      |             ^
  254 |         `can not run export while server is running, use next.stop() first`
  255 |       )
  256 |     }

  at NextStartInstance.build (lib/next-modes/next-start.ts:253:13)
  at Object.build (production/app-dir/server-action-period-hash/server-action-period-hash.test.ts:27:16)

…on Vc

nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 11, 2026

bgw mentioned this pull request Mar 11, 2026

docs(turbopack): Move singleton pattern documentation from mdbook to rustdoc #91175

Open

bgw requested review from a team and lukesandberg March 11, 2026 22:21

bgw marked this pull request as ready for review March 11, 2026 22:21

bgw force-pushed the bgw/turbo-tasks-singleton-docs branch from d67cf95 to 7ad9a2a Compare March 11, 2026 22:24

bgw force-pushed the bgw/into-trait-ref-inherent-method branch from 5f8a229 to de250e3 Compare March 11, 2026 22:25

mischnic approved these changes Mar 11, 2026

View reviewed changes

lukesandberg approved these changes Mar 11, 2026

View reviewed changes

bgw force-pushed the bgw/turbo-tasks-singleton-docs branch from 7ad9a2a to dedb6b8 Compare March 12, 2026 18:43

Turbopack: Remove the IntoTraitRef trait, make it an inherent method …

e8f37f2

…on Vc

bgw force-pushed the bgw/into-trait-ref-inherent-method branch from de250e3 to e8f37f2 Compare March 12, 2026 18:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turbopack: Remove the IntoTraitRef trait, make it an inherent method on Vc#91223

Turbopack: Remove the IntoTraitRef trait, make it an inherent method on Vc#91223
bgw wants to merge 1 commit intobgw/turbo-tasks-singleton-docsfrom
bgw/into-trait-ref-inherent-method

bgw commented Mar 11, 2026 •

edited

Loading

Uh oh!

bgw commented Mar 11, 2026

Uh oh!

codspeed-hq bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

nextjs-bot commented Mar 11, 2026

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

nextjs-bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bgw commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bgw commented Mar 11, 2026

Uh oh!

codspeed-hq bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

nextjs-bot commented Mar 11, 2026

Stats from current PR

✅ No significant changes detected

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

nextjs-bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failing test suites

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bgw commented Mar 11, 2026 •

edited

Loading

codspeed-hq bot commented Mar 11, 2026 •

edited

Loading

nextjs-bot commented Mar 11, 2026 •

edited

Loading