fix: prevent media type mismatch in closed media section reuse#363
Open
duyjack wants to merge 2 commits intoversatica:v3from
Open
fix: prevent media type mismatch in closed media section reuse#363duyjack wants to merge 2 commits intoversatica:v3from
duyjack wants to merge 2 commits intoversatica:v3from
Conversation
Member
|
Thanks @duyjack , we'll review and check in the following days. |
Astagor
reviewed
Apr 6, 2026
Member
|
This will take few more days as we'd like to make a further research and are currently short on time. |
Co-authored-by: Astagor <[email protected]>
|
My FF users are getting angry. Any info about the fix date? Also please see this #364 (comment) there might other things to fix for FF. |
Member
We are on vacation. Will check this on our arrival to normal life. Please open a separate ticket for that different issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue in
RemoteSdp.receive()where closed media sections could be recycledregardless of their media type, potentially causing type mismatch errors.
Changes
m.closed == trueANDm.getObject().type === kindMotivation
Previously, the code could recycle a closed
m=audiosection for newm=videomedia,which would cause type inconsistencies. The updated logic ensures type compatibility
when attempting to reuse closed media sections.
Testing
This fix prevents potential mismatches between the media section type and the requested kind,
improving the robustness of SDP media section management.