Skip to content

fix: prevent media type mismatch in closed media section reuse #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
duyjack wants to merge 2 commits into
base: v3
Choose a base branch
from
+2 −2
Open

fix: prevent media type mismatch in closed media section reuse #363

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ce3ea7
update remote sdp
duyjack Apr 1, 2026
9216041
Update comment in RemoteSdp.ts
duyjack Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/handlers/sdp/RemoteSdp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,8 @@ export class RemoteSdp {
});

// Let's try to recycle a closed media section (if any).
// NOTE: Yes, we can recycle a closed m=audio section with a new m=video.
const oldMediaSection = this._mediaSections.find(m => m.closed);
// NOTE: We cannot recycle a closed m=audio section as m=video (or vice versa). Firefox rejects the SDP when the media type of a recycled m-line changes.
const oldMediaSection = this._mediaSections.find(m => m.closed && m.getObject().type === kind);

if (oldMediaSection) {
this.replaceMediaSection(mediaSection, oldMediaSection.mid);
Expand Down