[RSDK-9677] add GetModelsFromModules to robot interface #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
JohnN193
commented
Jan 3, 2025
robot/impl/local_robot.go
Outdated
| @@ -1065,6 +1065,24 @@ func (r *localRobot) discoverRobotInternals(query resource.DiscoveryQuery) (inte | |||
| } | |||
| } | |||
|
|
|||
| func (r *localRobot) GetModelsFromModules(ctx context.Context) ([]*resource.ModuleModelDiscovery, error) { | |||
There was a problem hiding this comment.
@cheukt @zaporter-work wasn't sure whether everything should live at the robot level or if I should add something to the module manager to better surface these messages.
Also not sure who I should be having to review this stuff, I assumed it would be cheuk but if theres a more appropriate person lmk
There was a problem hiding this comment.
I think having more of the logic in the modmanager would make a bit more sense and make it easier to test. I can review but I didn't implement the original code nor am I the end consumer, would be good to have @zaporter-work as a reviewer too
There was a problem hiding this comment.
kk moved to module manager. Just need to add tests for the server & manager and it should be ready
JohnN193
changed the title
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
zaporter-work
approved these changes
Jan 27, 2025
Co-authored-by: Zack Porter <[email protected]>
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of GetModelsFromModules in Go. Currently working on the discovery service in a separate branch to make it easier on reviewers.
ticket: https://viam.atlassian.net/browse/RSDK-9677