[RSDK-9458] Remove 'Stream' from Camera interface I - cosmetic + test changes #4710
Conversation
viambot
added
the
safe to test
randhid
changed the title
viambot
added
safe to test
| @@ -95,6 +97,7 @@ func NewPinholeModelWithBrownConradyDistortion(pinholeCameraIntrinsics *transfor | |||
| return cameraModel | |||
| } | |||
|
|
|||
| // NewVideoSourceFromReader is DEPRECATED!!! Please implement cameras according to the camera.Camera interface. | |||
There was a problem hiding this comment.
How do the DEPRECATED comments work with staticcheck/linter in the RDK. Will linter fail or warn if code is added that uses the deprecated function?
There was a problem hiding this comment.
When the RPC or part of the RPC is deprecated in API - the linter will break, for this Deprecation string - I did not need to add "nolints" to the FFmpeg or webcam drivers to get the linter to pass, but that is based on rdk's tooling for its own linter. If a module has a more stringent linter that also checks the docstrings of the exported function somehow - I'd imagine that to break that go module's linter. I do not know if one such module exists.
| @@ -22,7 +22,7 @@ import ( | |||
| "go.viam.com/rdk/logging" | |||
| "go.viam.com/rdk/resource" | |||
| "go.viam.com/rdk/robot" | |||
| streamCamera "go.viam.com/rdk/robot/web/stream/camera" | |||
There was a problem hiding this comment.
Alias name change here makes sense to me.
| @@ -52,20 +47,6 @@ func (c *Camera) NextPointCloud(ctx context.Context) (pointcloud.PointCloud, err | |||
| return nil, errors.New("NextPointCloud unimplemented") | |||
| } | |||
|
|
|||
| // Stream calls the injected Stream or the real version. | |||
| func (c *Camera) Stream( | |||
There was a problem hiding this comment.
Were none of our tests using injected camera Stream?
There was a problem hiding this comment.
they were removed in a previous pr
Making https://github.com/viamrobotics/rdk/pull/4691/files smaller so we can focus on actual changes.