CLI binary download without include_binary; parallelize HTTP downloads #5587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several inefficiencies in binary data download logic:
getMatchingBinaryIDs, discarded, then again indownloadBinary).downloadBinary, once inbinaryDataToJSONLines).filter-based downloads.
downloadBinaryFilesInParallel.Key changes:
getMatchingBinaryIDswithgetMatchingBinaryMetadata: Returns fullBinaryDataobjects with metadata (including URIs) instead of just IDs.binaryData(filter-based): Collects all metadata once, then downloads in parallel.dataExportBinaryIDsAction(ID-based): Collects all metadata once, then downloads in parallel.downloadDataset: Eliminates triple metadata fetching, downloads files and writes JSON lines in parallel.downloadBinaryfunction: No longer needed after refactor.Benefits: