[APP-14503] #5608
Open
[APP-14503] #5608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
bashar-515
force-pushed
the
APP-14503
branch
from
ec59626 to
db32383
Compare
viambot
added
safe to test
bashar-515
force-pushed
the
APP-14503
branch
from
db32383 to
48a248e
Compare
viambot
added
safe to test
viambot
added
safe to test
reorder parameters implement GetAppBranding implement GetAppContent
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
bashar-515
commented
Jan 15, 2026
|
|
||
| // AppBranding contains metadata relevant to Viam Apps customizations. | ||
| // | ||
| //nolint:revive // AppBranding is clearer than Content in context of Viam Apps |
Member
Author
There was a problem hiding this comment.
Was getting a lint error regarding the stuttering in the exported name app.AppBranding
bashar-515
commented
Jan 15, 2026
|
|
||
| // AppContent defines where how to retrieve a Viam Apps app from GCS. | ||
| // | ||
| //nolint:revive // AppContent is clearer than Content in context of Viam Apps |
bashar-515
requested review from
a team,
allisonschiang and
stuqdog
and removed request for
a team and
stuqdog
stuqdog
approved these changes
Jan 15, 2026
Member
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
a couple small things (no need to rerequest review unless you think it would be useful) but generally this looks good to me!
| //nolint:revive // AppBranding is clearer than Content in context of Viam Apps | ||
| type AppBranding struct { | ||
| LogoPath string | ||
| TextCustomizations map[string]*TextOverrides |
Member
There was a problem hiding this comment.
(q) curious if this has to be pointers, given that the only field is already nilable?
|
|
||
| // AppBranding contains metadata relevant to Viam Apps customizations. | ||
| // | ||
| //nolint:revive // AppBranding is clearer than Content in context of Viam Apps |
| // | ||
| // ListMachineSummaries example: | ||
| // | ||
| // _, name, err := cloud.ListMachineSummaries( |
Member
There was a problem hiding this comment.
what is the _ value? it looks like ListMachineSummaries only returns two values, should this instead be locationSummaries, err := ...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket
This PR implements the API's we created for Viam Apps in the Go SDK. Previously, we had only included them in the typescript SDK since the Viam Apps server was written in Node. Now that we are porting the service over to Go, however, we'll need them in the Go SDK as well.