Skip to content

Remove LogPath and Path from Cloud config #5620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cheukt merged 3 commits into from
Jan 5, 2026
Merged

Remove LogPath and Path from Cloud config #5620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac9a1e6
remove fields
cheukt Dec 29, 2025
f1418ac
clarify doc
cheukt Dec 29, 2025
34bc0fb
Update config/config.go
cheukt Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,8 +555,6 @@ func (conf *Remote) validate(path string) error {

// A Cloud describes how to configure a robot controlled by the
// cloud.
// The cloud source could be anything that supports http.
// URL is constructed as $Path?id=ID and secret is put in a http header.
type Cloud struct {
ID string
Secret string
Expand All @@ -570,8 +568,6 @@ type Cloud struct {
LocalFQDN string
SignalingAddress string
SignalingInsecure bool
Path string
LogPath string
AppAddress string
RefreshInterval time.Duration

Expand All @@ -582,7 +578,10 @@ type Cloud struct {

// Note: keep this in sync with Cloud.
type cloudData struct {
// these three fields are only set within the config passed to the robot as an argumenet.
// For a working cloud managed robot, these three fields have to be set
// within the config passed to the robot through the --config argument.
// Cloud configs are not expected to return these fields, and these fields
// will be ignored if they are returned.
ID string `json:"id"`
Secret string `json:"secret,omitempty"`
AppAddress string `json:"app_address,omitempty"`
Expand All @@ -597,8 +596,6 @@ type cloudData struct {
LocalFQDN string `json:"local_fqdn"`
SignalingAddress string `json:"signaling_address"`
SignalingInsecure bool `json:"signaling_insecure,omitempty"`
Path string `json:"path,omitempty"`
LogPath string `json:"log_path,omitempty"`
RefreshInterval string `json:"refresh_interval,omitempty"`

// cached by us and fetched from a non-config endpoint.
Expand All @@ -625,8 +622,6 @@ func (config *Cloud) UnmarshalJSON(data []byte) error {
LocalFQDN: temp.LocalFQDN,
SignalingAddress: temp.SignalingAddress,
SignalingInsecure: temp.SignalingInsecure,
Path: temp.Path,
LogPath: temp.LogPath,
AppAddress: temp.AppAddress,
TLSCertificate: temp.TLSCertificate,
TLSPrivateKey: temp.TLSPrivateKey,
Expand Down Expand Up @@ -656,8 +651,6 @@ func (config Cloud) MarshalJSON() ([]byte, error) {
LocalFQDN: config.LocalFQDN,
SignalingAddress: config.SignalingAddress,
SignalingInsecure: config.SignalingInsecure,
Path: config.Path,
LogPath: config.LogPath,
AppAddress: config.AppAddress,
TLSCertificate: config.TLSCertificate,
TLSPrivateKey: config.TLSPrivateKey,
Expand Down
2 changes: 1 addition & 1 deletion web/server/entrypoint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ func RunServer(ctx context.Context, args []string, _ logging.Logger) (err error)

// Start remote logging with config from disk.
// This is to ensure we make our best effort to write logs for failures loading the remote config.
if cfgFromDisk.Cloud != nil && (cfgFromDisk.Cloud.LogPath != "" || cfgFromDisk.Cloud.AppAddress != "") {
if cfgFromDisk.Cloud != nil && cfgFromDisk.Cloud.AppAddress != "" {
netAppender, err := logging.NewNetAppender(
&logging.CloudConfig{
AppAddress: cfgFromDisk.Cloud.AppAddress,
Expand Down