RSDK-11726 — (STACKED) Deprecate GetImage and Format in Go SDK/RDK #5626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviamiller
reviewed
Jan 2, 2026
| return nil, camera.ImageMetadata{}, err | ||
| } | ||
| return imgBytes, resMetadata, nil | ||
| return nil, camera.ImageMetadata{}, errors.New("method GetImage is deprecated; please utilize GetImages instead") |
Member
There was a problem hiding this comment.
Should this be a warning? My understanding is that deprecation should be keeping the existing behavior for a period of time before fully removing.
Member
Author
There was a problem hiding this comment.
great point. Full deletion should come later
|
|
||
| // GetImage returns an image from a camera of the underlying robot. If a specific MIME type | ||
| // is requested and is not available, an error is returned. | ||
| func (s *serviceServer) GetImage( |
Member
There was a problem hiding this comment.
why fully removing it here but keeping it in the interface?
Member
Author
There was a problem hiding this comment.
I'm gonna change it to keep all the definitions but log deprecation
components/camera/client.go
Outdated
| } | ||
|
|
||
| return resp.Image, ImageMetadata{MimeType: resp.MimeType}, nil | ||
| return nil, ImageMetadata{}, errors.New("method GetImage is deprecated; please utilize GetImages instead") |
Member
There was a problem hiding this comment.
same question here about deprecation meaning
Member
Author
There was a problem hiding this comment.
I'm gonna change it to keep all the definitions but log deprecation
hexbabe
force-pushed
the
RSDK-11726
branch
3 times, most recently
from
efbc93d to
58ef59f
Compare
…h in stream server (viamrobotics#5603)
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
hexbabe
requested review from
allisonschiang and
lia-viam
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of RSDK-11831 and RSDK-11732 to reduce the diff surface area without actually merging the former two PRs.
It deprecates GetImage (logging deprecation warning), format and replaces all usages throughout RDK. And deletes GetImage testing.