App-14418: add more direction for module and model name #5629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
allisonschiang
commented
Jan 2, 2026
cli/module_generate.go
Outdated
| huh.NewInput(). | ||
| Title("Set a module name:"). | ||
| Description("The module name can contain only alphanumeric characters, dashes, and underscores."). | ||
| Description("This can be the name of the piece of hardware, the challenge you are trying to\n"+ |
Member
Author
There was a problem hiding this comment.
took wording from ticket but lmk if you want to change the verbage or wording!
Member
There was a problem hiding this comment.
pls add a new line before The module name can contain only...
allisonschiang
commented
Jan 2, 2026
| Description("This is the name of the new resource model that your module will provide.\n"+ | ||
| "The model name can contain only alphanumeric characters, dashes, and underscores."). | ||
| Placeholder("my-model"). | ||
| PlaceholderFunc(func() string { |
Member
Author
There was a problem hiding this comment.
the ticket calls to pre-populate text rather than have the background gray placeholder, but the huh package doesn't have the ValueFunc() implemented yet to dynamically change it
I tried:
- change the module.ModelName value with a validate() function, but its set when the form is created and doesn't change
- change the module.ModelName value by setting Value to a func() that returns resource type, but its set when the form is created and sets it to the first resource of
arm - change the module.ModelName with PlaceholderFunc, but it only changes the Placeholder (can't put an extra function in it to edit ModelName)
- create an Accessor function where you can create your own get() and set() function, but get() runs at form creation time so set to first resource of 'arm'
Didn't think it was worth it to split the form into two (ask resource name first and then prepopulate on another loaded form), switch packages, or make an open source contribution to huh package
allisonschiang
requested review from
a team,
lia-viam,
michaellee1019 and
njooma
and removed request for
a team
viambot
added
safe to test
allisonschiang
commented
Jan 6, 2026
| PlaceholderFunc(func() string { | ||
| return modelName(module) | ||
| }, &module.Resource). | ||
| SuggestionsFunc(func() []string { |
Member
Author
There was a problem hiding this comment.
the only suggestion that makes sense to make is the model name we recommend
njooma
approved these changes
Jan 7, 2026
cli/module_generate.go
Outdated
| huh.NewInput(). | ||
| Title("Set a module name:"). | ||
| Description("The module name can contain only alphanumeric characters, dashes, and underscores."). | ||
| Description("This can be the name of the piece of hardware, the challenge you are trying to\n"+ |
Member
There was a problem hiding this comment.
pls add a new line before The module name can contain only...
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo:
Screen.Recording.2026-01-06.at.2.50.52.PM.mov