Skip to content

support leading 'v' and trailing '-rc' in cloud build tag match #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abe-winter merged 2 commits into from
Jan 5, 2026
Merged

support leading 'v' and trailing '-rc' in cloud build tag match #5633

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
444bd4c
more flexible tag pattern for cloud build
abe-winter Jan 2, 2026
4c8f7fa
comment
abe-winter Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cli/module_generate/_templates/.github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@
on:
push:
tags:
- "[0-9]+.[0-9]+.[0-9]+" # the build-action will trigger on tags with the format 1.0.0
# we support 0.0.1, v0.0.1, 0.0.1-rc1, v0.0.1-rc1
- "v?[0-9]+.[0-9]+.[0-9]+"
- "v?[0-9]+.[0-9]+.[0-9]+-rc[0-9]+"
Comment on lines +6 to +7
Copy link
Member

@njooma njooma Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could do this in a single line: v?[0-9]+.[0-9]+.[0-9]+(?:-rc[0-9]+)?

Copy link
Member

@njooma njooma Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, both of these would accept v0.0.1-??? -- as the v0.0.1 part would match



jobs:
publish:
Expand Down