feature/gapless-albums: working gapless play for albums only. - #434
feature/gapless-albums: working gapless play for albums only.#434BowlOfSoup wants to merge 4 commits into
Conversation
|
@BowlOfSoup is attempting to deploy a commit to the Victor Alves' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hi @BowlOfSoup, thanks for the PR! Tested remotely and I could hear some minor clicks when the song changes (I was listening Pink Floyd's Dark Side of the Moon), but maybe is because I was using a tunnel to access externally, I'm gonna do more tests locally. Some things I noticed:
I was unable to do a complete code review for now, but I'm going to on the next few days. |
|
Valuable comments. Thanks. I didn't realize the MediaSession. |
|
@victoralvesf I fixed and (dev-)tested:
I've also double checked for clicks, but even with a VPN tunnel I couldn't reproduce it. Let me know if I can/should test with your library. |
|
Awesome! Let's get this in! |
|
@victoralvesf if you'd like changes, or have comments, let me know :) |
Since I'm an avid prog-rock listener, having setup my Navidrome server and using Aonsoku, I noticed that gapless play was not a feature yet. I've read #179 and I thought: lets give it a go.
I've implemented gapless playback so consecutive tracks from the same album play with no gap between them. It's opt-in and experimental*, off by default, under Settings > Audio > Playback. Playlists and shuffled queues are unaffected.
*It's not experimental in the sense that it sometimes does not work (it does in my tests), but I thought it would up the chance for approval and get people to (also) test the functionality.
How it works
transitionModesetting switches between the existing streaming<AudioPlayer>and a newGaplessSongPlayer.Tests
Notes
en.jsononly and can be picked up by Weblate for translation.