Skip to content

Rename FallListSelected sign group to FallListSelectedSign #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2025

Conversation

lambdalisue
Copy link
Collaborator

Summary

This PR renames the sign group from FallListSelected to FallListSelectedSign for consistency with naming conventions.

Changes

  • Renamed SIGN_GROUP_SELECTED constant from PopUpFallListSelected to PopUpFallListSelectedSign
  • Renamed SIGN_SELECTED constant from FallListSelected to FallListSelectedSign
  • Updated documentation to reflect the new sign group name
  • Updated the sign definition in the highlight setup

🤖 Generated with Claude Code

Copy link

codecov bot commented Aug 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.45%. Comparing base (e892695) to head (00d4630).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   82.14%   83.45%   +1.31%     
==========================================
  Files          27       31       +4     
  Lines        1798     1977     +179     
  Branches      185      200      +15     
==========================================
+ Hits         1477     1650     +173     
- Misses        318      324       +6     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lambdalisue lambdalisue merged commit abf9c78 into main Aug 2, 2025
6 checks passed
@lambdalisue lambdalisue deleted the fix-tag branch August 2, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant