Skip to content

Rename FallListSelected sign group to FallListSelectedSign #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ jobs:
- name: Perform pre-cache
run: |
deno cache \
--config ${DENOPS_TEST_DENOPS_PATH}/denops/@denops-private/deno.jsonc \
${DENOPS_TEST_DENOPS_PATH}/denops/@denops-private/mod.ts ./denops/fall/main.ts

- name: Test
Expand Down
4 changes: 2 additions & 2 deletions denops/fall/component/list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import type { Dimension } from "jsr:@vim-fall/core@^0.3.0/coordinator";
import { BaseComponent, ComponentProperties } from "./_component.ts";

export const HIGHLIGHT_MATCH = "FallListMatch";
export const SIGN_GROUP_SELECTED = "PopUpFallListSelected";
export const SIGN_SELECTED = "FallListSelected";
export const SIGN_GROUP_SELECTED = "PopUpFallListSelectedSign";
export const SIGN_SELECTED = "FallListSelectedSign";

/**
* Type representing the decoration properties of an item,
Expand Down
6 changes: 3 additions & 3 deletions doc/fall.txt
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,13 @@ For example:
-------------------------------------------------------------------------------
SIGN *fall-configuration-sign*

Use FallXXXXX sign groups to configure the picker window appearance. See
Use FallXXXXXSign sign groups to configure the picker window appearance. See
|fall-sign| for a list of available sign groups.

For example:
>vim
function! s:my_fall_style() abort
sign define FallListSelected text=*
sign define FallListSelectedSign text=*
endfunction

augroup fall_plugin_style
Expand Down Expand Up @@ -643,7 +643,7 @@ HIGHLIGHT *fall-highlight*
-----------------------------------------------------------------------------
SIGN *fall-sign*

*FallListSelected*
*FallListSelectedSign*
Indicator sign for the selected item in the list component.
Default to "»".

Expand Down
2 changes: 1 addition & 1 deletion plugin/fall/highlight.vim
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function! s:init() abort
" List
highlight default link FallListMatch Search
highlight default link FallListSelected CurSearch
sign define FallListSelected text=≫
sign define FallListSelectedSign text=≫

" Help
highlight default link FallHelpHeader Conceal
Expand Down
Loading