ensures double negative is evaluated correctly #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what's changed
Update the
negate
function in BinaryOperatorExpression to negate the existing value. This allows expressions with double negative, such asNOT (:gameboy IS NOT NULL)
, to negate correctly.Example
Prior to the change, the following query will return count 16 because
NOT ("gameboy" IS NOT NULL)
is evaluated toTRUE
and making the whole WHERE clause alwaysTRUE
. The expression,NOT ("gameboy" IS NOT NULL)
should beFALSE
because if"gameboy" IS NOT NULL
is true, thenNOT(TRUE)
isFALSE
After the change, the query returns 1 correctly.
Tests
Add tests with queries involving
IS NULL
ANDIS NOT NULL