Skip to content

ensures double negative is evaluated correctly #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

ensures double negative is evaluated correctly #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Query/Expression/BinaryOperatorExpression.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ public function __construct(
*/
public function negate()
{
$this->negated = true;
$this->negatedInt = 1;
$this->negated = !$this->negated;
$this->negatedInt = $this->negated ? 1 : 0;
}

/**
Expand Down
36 changes: 36 additions & 0 deletions tests/EndToEndTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,6 +1262,42 @@ public function testNegateOperationWithOr()
$this->assertSame([['count' => 9]], $query->fetchAll(\PDO::FETCH_ASSOC));
}

public function testNullEvaluation()
{
$pdo = self::getConnectionToFullDB(false);

// case 1, where console value is null
$query = $pdo->prepare("SELECT COUNT(*) as 'count' FROM `video_game_characters` WHERE (:console IS NULL AND `console` = 'gameboy') OR NOT (:console IS NULL)");
$query->bindValue(':console', NULL);
$query->execute();
$this->assertSame([['count' => 1]], $query->fetchAll(\PDO::FETCH_ASSOC));

// case 2, where console value is not null
$query = $pdo->prepare("SELECT COUNT(*) as 'count' FROM `video_game_characters` WHERE (:console IS NULL AND `console` = 'gameboy') OR NOT (:console IS NULL)");
$query->bindValue(':console', 'all');
$query->execute();
$this->assertSame([['count' => 16]], $query->fetchAll(\PDO::FETCH_ASSOC));
}

public function testNullWithDoubleNegativeEvaluation()
{
$pdo = self::getConnectionToFullDB(false);

//case 1, where console value is not null
$query = $pdo->prepare("SELECT COUNT(*) as 'count' FROM `video_game_characters` WHERE (:console IS NOT NULL AND `console` = :console) OR NOT (:console IS NOT NULL)");
$query->bindValue(':console', 'gameboy');
$query->execute();

$this->assertSame([['count' => 1]], $query->fetchAll(\PDO::FETCH_ASSOC));

//case 1, where console value is null
$query = $pdo->prepare("SELECT COUNT(*) as 'count' FROM `video_game_characters` WHERE (:console IS NOT NULL AND `console` = :console) OR NOT (:console IS NOT NULL)");
$query->bindValue(':console', NULL);
$query->execute();

$this->assertSame([['count' => 16]], $query->fetchAll(\PDO::FETCH_ASSOC));
}

private static function getPdo(string $connection_string, bool $strict_mode = false) : \PDO
{
$options = $strict_mode ? [\PDO::MYSQL_ATTR_INIT_COMMAND => 'SET sql_mode="STRICT_ALL_TABLES"'] : [];
Expand Down
Loading