feat(effects): integrate analytic GTAO ambient composition#2759
Draft
ibgreen-openai wants to merge 1 commit into
Draft
feat(effects): integrate analytic GTAO ambient composition#2759ibgreen-openai wants to merge 1 commit into
ibgreen-openai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Changes
frameIndex.composition: 'ambient-only'and exportgtaoAmbientComposite, while retaining the existing whole-color composite by default.deferredAmbientLightingextraction and update the deferred-rendering example to bind isolated ambient radiance.Verification
env -u YARN_NO_PROXY corepack yarn lint fixenv -u YARN_NO_PROXY corepack yarn lintenv -u YARN_NO_PROXY corepack yarn test-node— 178 passed, 2 skipped.env -u YARN_NO_PROXY corepack yarn build— all packages compile.env -u YARN_NO_PROXY corepack yarn examples:typecheck— all 31 example workspaces pass.env -u YARN_NO_PROXY corepack yarn website:build— production client, server, and search index build.env -u YARN_NO_PROXY corepack yarn test-headless modules/effects/test/passes/advanced-effects.spec.ts modules/effects/test/passes/postprocessing-wgsl.spec.ts modules/experimental/test/rendering/deferred-lighting.spec.ts— 8 Chromium/WebGPU tests pass.env -u YARN_NO_PROXY corepack yarn testruns 178 node tests and 1,303 headless cases; one unchanged, reproducible existing failure remains inmodules/arrow-layers/test/layers/arrow-layers.spec.ts(polygonViewportUniformsmissing / polygon storage instances not drawable). The affected Arrow files have no diff frommaster.